From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C92CEC43217 for ; Wed, 29 Sep 2021 13:09:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B0D1E613D3 for ; Wed, 29 Sep 2021 13:09:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344057AbhI2NLH (ORCPT ); Wed, 29 Sep 2021 09:11:07 -0400 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:48734 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344026AbhI2NLE (ORCPT ); Wed, 29 Sep 2021 09:11:04 -0400 Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 215463F4BE for ; Wed, 29 Sep 2021 13:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632920963; bh=KsbVur2/qli+4fCqIZBdqDED21IaMcFYxs808+TH5nI=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=mpYcIE9MAMDMvArCyDVt6zal1SjxSyX8EldFAkgzHx8d/XrbExhRjfJEHyDh+JcWY 9oSARNIk5TM1FvFfmgKqPcZ51GiE+bjvBIh5pKGpv+Uwqi/iYb4FAIl2A9w8bsaElh Hf1y5z6yhZD1u/1gu86/Uumdbtalc00YlFGqVvcbZsWvmejbHGnQQHCXzioLtMxcwI 3LzaQKlCIf744Ad4SAaEl+hJk2JiHkfZ5aEUMggU/ZsFT+aQMEIDImyS2T6/6KuOl2 x5af2w3eQMwsnhUypc+N6KRm7+NarBlwSaytxpyehiRcwTuUXdw269ZF9Xxc1G4dTO vtIFL3hD7nGVg== Received: by mail-lf1-f72.google.com with SMTP id q4-20020ac25284000000b003fcebb305a6so2306910lfm.15 for ; Wed, 29 Sep 2021 06:09:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KsbVur2/qli+4fCqIZBdqDED21IaMcFYxs808+TH5nI=; b=7rjG4PT1tzrngp93tNnzlV1t69GVTuyxLIYaV5VhDJ3QxVDaxqOGgXgsOMg9c6Znw7 xxfXGgM93nSOy7Bfjk8G+kEwqz6bGoW2wG0fnnTRpVrTDUwDy/v7ugPaSaAxxyJQMV9z r8e58fQPK+tX+Imjb6GOnSg/lQYGVU6+HVAnEfvSn/Cm3Gtr3RU6PrdbtrEISxmZsWk/ tOi2gxQyRfM/jDPwQcRFL/ItOFepplcUnxGHy4dyxMNhR4phpeYjH2f/BKuj7sXEQCTZ YzHrOU/uk+k73e9ChUvRG1LY9Z0UYXF557V1saNVnwoK7O0T+JWJPq8EYFzwY22umuAE 9fnA== X-Gm-Message-State: AOAM530O2fOIHny+el9IDcgI8ilNKfUGF2S5dRbtIluectyFD4la0d/v /4pl6OZa1bluhRuTh4mB5WLD3xx/PKzStyW83UVAT9xJv+9IIOKIznFVo2PbUdj6VTFWViLErKl I7ssc2GGgfD+g3ZwYQE0Bx2iKoaSqRr/vWIzbzPuAGQ== X-Received: by 2002:ac2:59c7:: with SMTP id x7mr11996682lfn.662.1632920962440; Wed, 29 Sep 2021 06:09:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKrXQMmrpXBJdFGfniYnh95CJW4r5XX/GOWAswOXl0aBJ33mQHCMYimiRr8Trj3H0MHLM7Ow== X-Received: by 2002:ac2:59c7:: with SMTP id x7mr11996657lfn.662.1632920962259; Wed, 29 Sep 2021 06:09:22 -0700 (PDT) Received: from [192.168.0.197] ([193.178.187.25]) by smtp.gmail.com with ESMTPSA id b22sm241800lfs.27.2021.09.29.06.09.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Sep 2021 06:09:21 -0700 (PDT) Subject: Re: [PATCH v2 07/12] clk: samsung: set exynos arm64 clk driver as tristate To: Will McVicker , Russell King , Catalin Marinas , Will Deacon , Michael Turquette , Stephen Boyd , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Linus Walleij , Alessandro Zummo , Alexandre Belloni , John Stultz , Thomas Gleixner Cc: Lee Jones , Geert Uytterhoeven , Saravana Kannan , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org References: <20210928235635.1348330-1-willmcvicker@google.com> <20210928235635.1348330-8-willmcvicker@google.com> From: Krzysztof Kozlowski Message-ID: Date: Wed, 29 Sep 2021 15:09:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210928235635.1348330-8-willmcvicker@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/09/2021 01:56, Will McVicker wrote: > This sets the COMMON_CLK_SAMSUNG and EXYNOS_ARM64_COMMON_CLK drivers as > tristate so that we can compile them as modules. This is not the only thing you are doing. You are removing the enforced built-in and this must be here explained and tested. The policy so far was that all S3C, S5P and Exynos supported platforms select (enforce) necessary drivers. Please explain in commit msg reasoning why this is being changed and what's the impact (whether it actually works). What is more, it seems you entirely ignored Geert's comments. I pointed attention to it last time and you just said you will send v2 instead of joining discussion. It's a NAK for this reason - ignoring what Geert brought: you just broke distro configs for Exynos. Best regards, Krzysztof