From: Johan Jonker <jbx6244@gmail.com>
To: Mikhail Rudenko <mike.rudenko@gmail.com>, linux-phy@lists.infradead.org
Cc: linux-media@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>, Marc Zyngier <maz@kernel.org>,
Helen Koike <helen.koike@collabora.com>,
Elaine Zhang <zhangqing@rock-chips.com>,
Shunqian Zheng <zhengsq@rock-chips.com>,
Robin Murphy <robin.murphy@arm.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 5/5] arm64: dts: rockchip: add mipi-dphy-tx1rx1 for rk3399
Date: Mon, 30 Aug 2021 23:12:00 +0200 [thread overview]
Message-ID: <ac38a6ce-19f6-8d30-6070-55b78cc082e2@gmail.com> (raw)
In-Reply-To: <20210830180758.251390-6-mike.rudenko@gmail.com>
Hi Mikhail,
On 8/30/21 8:07 PM, Mikhail Rudenko wrote:
> Add DT node for RX mode of RK3399 TX1RX1 D-PHY.
>
> Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 3871c7fd83b0..2e4513275a87 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1902,6 +1902,21 @@ mipi1_in_vopl: endpoint@1 {
> };
> };
>
> + mipi_dphy_tx1rx1: mipi-dphy-tx1rx1@ff968000 {
> + compatible = "rockchip,rk3399-mipi-dphy-tx1rx1";
> + reg = <0x0 0xff968000 0x0 0x8000>;
> + clocks = <&cru SCLK_MIPIDPHY_REF>,
> + <&cru SCLK_DPHY_TX1RX1_CFG>,
> + <&cru PCLK_VIO_GRF>,
> + <&cru PCLK_MIPI_DSI1>;
> + clock-names = "dphy-ref", "dphy-cfg",
> + "grf", "dsi";
Could you fix the alignment a bit with extra spaces?
> + rockchip,grf = <&grf>;
> + power-domains = <&power RK3399_PD_VIO>;
Sort in alphabetical order.
> + #phy-cells = <0>;
> + status = "disabled";
> + };
> +
> edp: edp@ff970000 {
> compatible = "rockchip,rk3399-edp";
> reg = <0x0 0xff970000 0x0 0x8000>;
>
next prev parent reply other threads:[~2021-08-30 21:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 18:07 [PATCH v1 0/5] phy: phy-rockchip-dphy-rx0: add support for tx1rx1 rx mode Mikhail Rudenko
2021-08-30 18:07 ` [PATCH v1 1/5] phy: phy-rockchip-dphy-rx0: refactor for tx1rx1 addition Mikhail Rudenko
2021-08-30 20:45 ` Heiko Stübner
2021-08-31 0:41 ` Ezequiel Garcia
2021-08-30 18:07 ` [PATCH v1 2/5] phy: phy-rockchip-dphy-rx0: add support for tx1rx1 in receive mode Mikhail Rudenko
2021-08-30 18:07 ` [PATCH v1 3/5] phy: rename phy-rockchip-dphy-rx0 to phy-rockchip-dphy-rx Mikhail Rudenko
2021-08-30 18:07 ` [PATCH v1 4/5] dt-bindings: phy: phy-rockchip-dphy-rx0: add support for tx1rx1 phy Mikhail Rudenko
2021-08-30 21:00 ` Johan Jonker
2021-08-30 22:06 ` Johan Jonker
2021-08-31 0:03 ` Rob Herring
2021-08-30 18:07 ` [PATCH v1 5/5] arm64: dts: rockchip: add mipi-dphy-tx1rx1 for rk3399 Mikhail Rudenko
2021-08-30 21:12 ` Johan Jonker [this message]
2021-08-30 21:50 ` Johan Jonker
2021-08-31 12:58 ` [PATCH v1 0/5] phy: phy-rockchip-dphy-rx0: add support for tx1rx1 rx mode Mikhail Rudenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac38a6ce-19f6-8d30-6070-55b78cc082e2@gmail.com \
--to=jbx6244@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=helen.koike@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maz@kernel.org \
--cc=mike.rudenko@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=zhangqing@rock-chips.com \
--cc=zhengsq@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).