From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934751AbdK2Rj3 (ORCPT ); Wed, 29 Nov 2017 12:39:29 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:42936 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934275AbdK2RjC (ORCPT ); Wed, 29 Nov 2017 12:39:02 -0500 X-Google-Smtp-Source: AGs4zMaw44qraJBxexrKSdb0qWNWcmPLlkWXa3Kb30RoEbdJeP2y0x0U7j5AOblLPl1I6xmYoO/Y6Q== Subject: Re: [v2,01/12] hwrng: bcm2835 - Obtain base register via resource To: Herbert Xu , Florian Fainelli Cc: linux-kernel@vger.kernel.org, Matt Mackall , Rob Herring , Mark Rutland , Ray Jui , Scott Branden , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , Eric Anholt , Stefan Wahren , PrasannaKumar Muralidharan , Russell King , Krzysztof Kozlowski , Harald Freudenberger , Sean Wang , Martin Kaiser , Steffen Trumtrar , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" References: <20171108004449.32730-2-f.fainelli@gmail.com> <20171129063028.GB21594@gondor.apana.org.au> From: Florian Fainelli Message-ID: Date: Wed, 29 Nov 2017 09:38:52 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171129063028.GB21594@gondor.apana.org.au> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/28/2017 10:30 PM, Herbert Xu wrote: > On Tue, Nov 07, 2017 at 04:44:38PM -0800, Florian Fainelli wrote: >> In preparation for consolidating bcm63xx-rng into bcm2835-rng, make sure >> that we obtain the base register via platform_get_resource() since we >> need to support the non-DT enabled MIPS-based BCM63xx DSL SoCs. >> >> Signed-off-by: Florian Fainelli > > All applied. Thanks. Hu, okay, I actually had a v3 prepared that I was going to post addressing some of the comments. Should I send an incremental set of changes now? -- Florian