From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 803DFC4361B for ; Thu, 10 Dec 2020 12:48:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C1F723B85 for ; Thu, 10 Dec 2020 12:48:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732631AbgLJMsj (ORCPT ); Thu, 10 Dec 2020 07:48:39 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:62406 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728735AbgLJMsj (ORCPT ); Thu, 10 Dec 2020 07:48:39 -0500 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0BACWnFE144834; Thu, 10 Dec 2020 07:47:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=YBczKy8t1PSc0xrxwIaZ2Mtomm6wWxLCXRKU48zsWk0=; b=jxWlbRXpdnok5xK0+UTcfRzzhatc2vQAYgF79r+/8DlsDBitTlT4C+QSnavDGoUuWMkv azjaZm+15GSzn5A1hQ3YJ61k6B9JUuTQd0/ppUiHfHBcNioWFqNdcDQE8G6UZOgUD9Wj 4yW7CXfgIJYxQ8148MBa8uJ9OVEH9zXhThUldjjyr1EH7CMKWF1KK72NyCF3n91ERQV1 PtCWH2t/D/+0S5cwHRbRTFKrJUu3ffXVyVlkRWDCNfLbmzyqXsTZeZwRVEM7Im3rQ9yZ y2vawyCN9fBVA4bRw++luG86CI8+d6gXjhcra/zfYwU+YbEMmbisD0CpYZnriCErTw/P nw== Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0b-001b2d01.pphosted.com with ESMTP id 35bksbge2v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Dec 2020 07:47:47 -0500 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0BACVuqo021329; Thu, 10 Dec 2020 12:47:45 GMT Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by ppma05fra.de.ibm.com with ESMTP id 35958q237j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Dec 2020 12:47:45 +0000 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0BAClhkA34013510 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Dec 2020 12:47:43 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 480FD4204D; Thu, 10 Dec 2020 12:47:43 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F2FB54204B; Thu, 10 Dec 2020 12:47:42 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 10 Dec 2020 12:47:42 +0000 (GMT) Received: from [9.206.213.130] (unknown [9.206.213.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id C3C32609A5; Thu, 10 Dec 2020 23:47:41 +1100 (AEDT) Subject: Re: [PATCH] powerpc/rtas: fix typo of ibm,open-errinjct in rtas filter To: Tyrel Datwyler , mpe@ellerman.id.au Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20201208195434.8289-1-tyreld@linux.ibm.com> From: Andrew Donnellan Message-ID: Date: Thu, 10 Dec 2020 23:47:41 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20201208195434.8289-1-tyreld@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343,18.0.737 definitions=2020-12-10_05:2020-12-09,2020-12-10 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxlogscore=999 bulkscore=0 priorityscore=1501 spamscore=0 clxscore=1015 impostorscore=0 mlxscore=0 malwarescore=0 adultscore=0 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012100080 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/12/20 6:54 am, Tyrel Datwyler wrote: > Commit bd59380c5ba4 ("powerpc/rtas: Restrict RTAS requests from userspace") > introduced the following error when invoking the errinjct userspace > tool. > > [root@ltcalpine2-lp5 librtas]# errinjct open > [327884.071171] sys_rtas: RTAS call blocked - exploit attempt? > [327884.071186] sys_rtas: token=0x26, nargs=0 (called by errinjct) > errinjct: Could not open RTAS error injection facility > errinjct: librtas: open: Unexpected I/O error > > The entry for ibm,open-errinjct in rtas_filter array has a typo where > the "j" is omitted in the rtas call name. After fixing this typo the > errinjct tool functions again as expected. > > [root@ltcalpine2-lp5 linux]# errinjct open > RTAS error injection facility open, token = 1 > > fixes: bd59380c5ba4 ("powerpc/rtas: Restrict RTAS requests from userspace") > Signed-off-by: Tyrel Datwyler Thanks for catching this! Acked-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra ajd@linux.ibm.com IBM Australia Limited