linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shuah Khan <shuah@kernel.org>
To: Michael Grzeschik <m.grzeschik@pengutronix.de>,
	linux-usb@vger.kernel.org
Cc: valentina.manea.m@gmail.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de,
	Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH v3] usbip: dynamically allocate idev by nports found in sysfs
Date: Wed, 23 May 2018 10:44:57 -0600	[thread overview]
Message-ID: <ac85c509-72ec-c126-afb7-521ddde87ec1@kernel.org> (raw)
In-Reply-To: <20180523092256.25922-1-m.grzeschik@pengutronix.de>

On 05/23/2018 03:22 AM, Michael Grzeschik wrote:
> As the amount of available ports varies by the kernels build
> configuration. To remove the limitation of the fixed 128 ports
> we allocate the amount of idevs by using the number we get
> from the kernel.
> 
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> ---
> v1 -> v2: - reworked memory allocation into one calloc call
>           - added error path on allocation failure
> v2 -> v3: - moved check for available nports to beginning of function
> 

Hmm. With this patch I see a segfault when I run usbip port command.
I think this patch is incomplete and more changes are needed to the
code that references the idev array.

I can't take this patch.

thanks,
-- Shuah

  reply	other threads:[~2018-05-23 16:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18 14:39 [PATCH] usbip: dynamically allocate idev by nports found in sysfs Michael Grzeschik
2018-05-22 16:06 ` Shuah Khan
2018-05-22 17:04   ` [PATCH v2] " Michael Grzeschik
2018-05-22 22:56     ` Shuah Khan
2018-05-23  9:22       ` [PATCH v3] " Michael Grzeschik
2018-05-23 16:44         ` Shuah Khan [this message]
2018-05-23 21:01           ` Michael Grzeschik
2018-05-24  7:34           ` Michael Grzeschik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac85c509-72ec-c126-afb7-521ddde87ec1@kernel.org \
    --to=shuah@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.grzeschik@pengutronix.de \
    --cc=valentina.manea.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).