From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F0D4C56201 for ; Thu, 12 Nov 2020 16:17:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2C55206D5 for ; Thu, 12 Nov 2020 16:17:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XGK9rSZ4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728797AbgKLQRa (ORCPT ); Thu, 12 Nov 2020 11:17:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728414AbgKLQR3 (ORCPT ); Thu, 12 Nov 2020 11:17:29 -0500 Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD29EC0613D4 for ; Thu, 12 Nov 2020 08:17:29 -0800 (PST) Received: by mail-io1-xd42.google.com with SMTP id n12so6626487ioc.2 for ; Thu, 12 Nov 2020 08:17:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wql1vihawUfdAi3RlY4nIdk+T+uHWLK8xWelQf83+v0=; b=XGK9rSZ4Jlw8Ny7jjfM45f/d/TXlV384MoHJ2uvw3Y6gw48JwOkWivUOI8e5Q5lvbF PQiapsdlvJOJr1HVrg7CwjKFhXMZQ5aPtIjVAFS5Iu38tKzVCJUtoHC5qP1ivjNNYoWj 0Oaobz7abvCZPJsIyn8DnmnJHL6o+KY7IrJM0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wql1vihawUfdAi3RlY4nIdk+T+uHWLK8xWelQf83+v0=; b=AtRBClI/BBX5nK+VXNWtmxbazCuBEitAtEtfmTUReFO3Dadxan+laWRf5F8t1I48LH Ve031/k6Lguz0we7DdeczWqSEZ3Dsj+SHudDzm06QI35jBSlKdN6TosUHjfbA15XlAnO ZmL9JPmGsKsRQ2cg1n4udJj4SeKsCVO254L45lRwaX/AatZhOHnYkkal+8XXQ8ovV9Du snlhOH1YvqEZxBZecJVGLjzpqm89aqVftQY+OMBBa6/s1g0HkV/QvcTPVVeO23rrbuuF 6uHzSo/5YuhJa9bEjApM+dCu7YZPT6En76jaKXxQ5YbvFC4CXTWJtuwrY/Uk/9GtYn8P 7QXw== X-Gm-Message-State: AOAM5333qgT+C6PtN/ukOpLrfodkjOZxpuaZVM5PGP4wKaXzHR3rOoJb ilnrW7TgU4guX5tN8shPrchbtRxlpOkopw== X-Google-Smtp-Source: ABdhPJyqzypqNPPq9OK4FbXBbf/5CC1EZ1loHBSIoVtM9ytn1dFMwbuWGV1X3KSy08ytcv5sb9O63A== X-Received: by 2002:a6b:5b0e:: with SMTP id v14mr23225825ioh.155.1605197849077; Thu, 12 Nov 2020 08:17:29 -0800 (PST) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id l65sm3630702ill.18.2020.11.12.08.17.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Nov 2020 08:17:28 -0800 (PST) Subject: Re: [PATCH 01/13] seqnum_ops: Introduce Sequence Number Ops To: Matthew Wilcox Cc: Kees Cook , Greg KH , corbet@lwn.net, peterz@infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org References: <202011101614.E7D880689@keescook> <3075a4fd-8615-1459-2b20-b7d9d2be34ff@linuxfoundation.org> <20201112123621.GY17076@casper.infradead.org> From: Shuah Khan Message-ID: Date: Thu, 12 Nov 2020 09:17:27 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: <20201112123621.GY17076@casper.infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/12/20 5:36 AM, Matthew Wilcox wrote: > On Wed, Nov 11, 2020 at 12:23:03PM -0700, Shuah Khan wrote: >>> Agreed: this is a clear wrapping sequence counter. It's only abuse would >>> be using it in a place where wrapping actually is _not_ safe. (bikeshed: >>> can we call it wrap_u32 and wrap_u64?) >> >> Still like seqnum_ops. >> >> There is seqcount_t in seqlock.h which is a totally different feature. > > Yes, and that's why this new thing, whatever it is called should not > have the word "sequence" in it. People will get it confused. Any suggestions for name. I am bad with coming up with names. How does Statcnt API and struct statcnt along the lines of your name suggestions in your previous email? > "ops" in Linux means "vector of methods", like a_ops, f_op, i_op, fl_ops. > We also have "this_cpu_ops, atomic_ops, local_ops" etc. core-api. The ops in the name is to keep with that nomenclature since these are atomic ops. thanks, -- Shuah