From: Sudeep Holla <sudeep.holla@arm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Sudeep Holla <sudeep.holla@arm.com>,
linux-kernel@vger.kernel.org, Scott Wood <oss@buserror.net>,
Yangbo Lu <yangbo.lu@nxp.com>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 1/2] soc: fsl: make it explicitly non-modular
Date: Wed, 16 Nov 2016 16:41:29 +0000 [thread overview]
Message-ID: <acb8b99f-cb71-6614-b90e-c62494746fc8@arm.com> (raw)
In-Reply-To: <1479314367-9169-1-git-send-email-sudeep.holla@arm.com>
On 16/11/16 16:39, Sudeep Holla wrote:
> The Kconfig currently controlling compilation of this code is:
>
> drivers/soc/fsl/Kconfig:config FSL_GUTS
> drivers/soc/fsl/Kconfig: bool
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>
> Since module_init was not in use by this code, the init ordering
> remains unchanged with this commit.
>
Sorry I forgot to append -next as these are applicable only to linux-next
> Cc: Scott Wood <oss@buserror.net>
> Cc: Yangbo Lu <yangbo.lu@nxp.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> drivers/soc/fsl/guts.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c
> index 0ac88263c2d7..885409d84eb2 100644
> --- a/drivers/soc/fsl/guts.c
> +++ b/drivers/soc/fsl/guts.c
> @@ -11,7 +11,6 @@
>
> #include <linux/io.h>
> #include <linux/slab.h>
> -#include <linux/module.h>
> #include <linux/of_fdt.h>
> #include <linux/sys_soc.h>
> #include <linux/of_address.h>
> @@ -212,7 +211,6 @@ static const struct of_device_id fsl_guts_of_match[] = {
> { .compatible = "fsl,ls2080a-dcfg", },
> {}
> };
> -MODULE_DEVICE_TABLE(of, fsl_guts_of_match);
>
> static struct platform_driver fsl_guts_driver = {
> .driver = {
> @@ -228,9 +226,3 @@ static int __init fsl_guts_init(void)
> return platform_driver_register(&fsl_guts_driver);
> }
> core_initcall(fsl_guts_init);
> -
> -static void __exit fsl_guts_exit(void)
> -{
> - platform_driver_unregister(&fsl_guts_driver);
> -}
> -module_exit(fsl_guts_exit);
>
--
Regards,
Sudeep
next prev parent reply other threads:[~2016-11-16 16:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 16:39 [PATCH 1/2] soc: fsl: make it explicitly non-modular Sudeep Holla
2016-11-16 16:39 ` [PATCH 2/2] soc: fsl: fix section mismatch build warnings Sudeep Holla
2016-11-16 17:07 ` Arnd Bergmann
2016-11-16 17:10 ` Sudeep Holla
2016-11-17 15:11 ` [PATCH v2 -next] " Sudeep Holla
2016-11-17 15:25 ` Arnd Bergmann
2016-11-18 14:30 ` Ulf Hansson
2016-11-16 16:41 ` Sudeep Holla [this message]
2016-11-17 11:48 ` [PATCH 1/2] soc: fsl: make it explicitly non-modular Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acb8b99f-cb71-6614-b90e-c62494746fc8@arm.com \
--to=sudeep.holla@arm.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oss@buserror.net \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).