From: Yang Shi <yang.shi@linux.alibaba.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: ktkhai@virtuozzo.com, kirill.shutemov@linux.intel.com,
hannes@cmpxchg.org, mhocko@suse.com, hughd@google.com,
shakeelb@google.com, rientjes@google.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] mm: thp: make deferred split shrinker memcg aware
Date: Tue, 11 Jun 2019 22:06:36 -0700 [thread overview]
Message-ID: <ace52062-e6be-a3f2-7ef1-d8612f3a76f9@linux.alibaba.com> (raw)
In-Reply-To: <20190612024747.f5nsol7ntvubjckq@box>
On 6/11/19 7:47 PM, Kirill A. Shutemov wrote:
> On Fri, Jun 07, 2019 at 02:07:37PM +0800, Yang Shi wrote:
>> + /*
>> + * The THP may be not on LRU at this point, e.g. the old page of
>> + * NUMA migration. And PageTransHuge is not enough to distinguish
>> + * with other compound page, e.g. skb, THP destructor is not used
>> + * anymore and will be removed, so the compound order sounds like
>> + * the only choice here.
>> + */
>> + if (PageTransHuge(page) && compound_order(page) == HPAGE_PMD_ORDER) {
> What happens if the page is the same order as THP is not THP? Why removing
It may corrupt the deferred split queue since it is never added into the
list, but deleted here.
> of destructor is required?
Due to the change to free_transhuge_page() (extracted deferred split
queue manipulation and moved before memcg uncharge since
page->mem_cgroup is needed), it just calls free_compound_page(). So, it
sounds pointless to still keep THP specific destructor.
It looks there is not a good way to tell if the compound page is THP in
free_page path or not, we may keep the destructor just for this?
>
next prev parent reply other threads:[~2019-06-12 5:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 6:07 [v2 PATCH 0/4] Make deferred split shrinker memcg aware Yang Shi
2019-06-07 6:07 ` [PATCH 1/4] mm: thp: extract split_queue_* into a struct Yang Shi
2019-06-07 6:07 ` [PATCH 2/4] mm: thp: make deferred split shrinker memcg aware Yang Shi
2019-06-10 8:21 ` Kirill Tkhai
2019-06-10 17:23 ` Yang Shi
2019-06-12 2:47 ` Kirill A. Shutemov
2019-06-12 5:06 ` Yang Shi [this message]
2019-06-12 10:09 ` Kirill A. Shutemov
2019-06-12 17:13 ` Yang Shi
2019-06-07 6:07 ` [PATCH 3/4] mm: thp: remove THP destructor Yang Shi
2019-06-07 6:07 ` [PATCH 4/4] mm: shrinker: make shrinker not depend on memcg kmem Yang Shi
2019-06-12 2:52 ` Kirill A. Shutemov
2019-06-12 5:07 ` Yang Shi
2019-06-12 10:11 ` Kirill A. Shutemov
2019-06-12 17:20 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ace52062-e6be-a3f2-7ef1-d8612f3a76f9@linux.alibaba.com \
--to=yang.shi@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).