From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BE1CC433EF for ; Thu, 2 Dec 2021 16:03:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347760AbhLBQGW (ORCPT ); Thu, 2 Dec 2021 11:06:22 -0500 Received: from srv6.fidu.org ([159.69.62.71]:52278 "EHLO srv6.fidu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242463AbhLBQGQ (ORCPT ); Thu, 2 Dec 2021 11:06:16 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by srv6.fidu.org (Postfix) with ESMTP id F1FD9C80089; Thu, 2 Dec 2021 17:02:51 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at srv6.fidu.org Received: from srv6.fidu.org ([127.0.0.1]) by localhost (srv6.fidu.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 5ZuMYjBuvyF4; Thu, 2 Dec 2021 17:02:51 +0100 (CET) Received: from [192.168.178.21] (host-212-18-30-247.customer.m-online.net [212.18.30.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: wse@tuxedocomputers.com) by srv6.fidu.org (Postfix) with ESMTPSA id 90911C80086; Thu, 2 Dec 2021 17:02:51 +0100 (CET) Subject: Re: [PATCH] ALSA: hda/realtek: Fix quirk for TongFang PHxTxX1 To: Takashi Iwai Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20211202152843.818617-1-wse@tuxedocomputers.com> From: Werner Sembach Message-ID: Date: Thu, 2 Dec 2021 17:02:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 02.12.21 um 16:35 schrieb Takashi Iwai: > On Thu, 02 Dec 2021 16:28:43 +0100, > Werner Sembach wrote: >> This fixes the SND_PCI_QUIRK(...) of the TongFang PHxTxX1 barebone. This >> fixes the issue of sound not working after s3 suspend. >> >> When waking up from s3 suspend the Coef 0x10 is set to 0x0220 instead of >> 0x0020. Setting the value manually makes the sound work again. This patch >> does this automatically. >> >> While being on it, I also fixed the comment formatting of the quirk. >> >> Signed-off-by: Werner Sembach >> Cc: > Please try to put Fixes tag as this is a fix for the existing change. Sorry, wasn't aware of this. I guess it's [PATCH Fixes] as the beginning of the subject line? > > The code change looks almost good, but just minor nitpicking: > >> --- >> sound/pci/hda/patch_realtek.c | 25 ++++++++++++++----------- >> 1 file changed, 14 insertions(+), 11 deletions(-) >> >> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c >> index 9ce7457533c96..d3a16843c7afd 100644 >> --- a/sound/pci/hda/patch_realtek.c >> +++ b/sound/pci/hda/patch_realtek.c >> @@ -6503,22 +6503,25 @@ static void alc287_fixup_legion_15imhg05_speakers(struct hda_codec *codec, >> /* for alc285_fixup_ideapad_s740_coef() */ >> #include "ideapad_s740_helper.c" >> >> +static const struct coef_fw alc256_fixup_tongfang_reset_persistent_settings_coefs[] = { > The variable name is unnecessarily too long. Please use a shorter > one. Done. > >> + WRITE_COEF(0x10, 0x0020), WRITE_COEF(0x24, 0x0000), WRITE_COEF(0x26, 0x0000), >> + WRITE_COEF(0x29, 0x3000), WRITE_COEF(0x37, 0xfe05), WRITE_COEF(0x45, 0x5089), > Try to keep the line in 80 column. It's OK to take a longer if it has > to be, but in a case like this, it doesn't need to be that long. Wrong tab width in my editor so I didn't see it, fixed in v2. Compiling and testing now. Kind regards, Werner Sembach > > > thanks, > > Takashi > >> + {} >> +}; >> + >> static void alc256_fixup_tongfang_reset_persistent_settings(struct hda_codec *codec, >> const struct hda_fixup *fix, >> int action) >> { >> /* >> - * A certain other OS sets these coeffs to different values. On at least one TongFang >> - * barebone these settings might survive even a cold reboot. So to restore a clean slate the >> - * values are explicitly reset to default here. Without this, the external microphone is >> - * always in a plugged-in state, while the internal microphone is always in an unplugged >> - * state, breaking the ability to use the internal microphone. >> - */ >> - alc_write_coef_idx(codec, 0x24, 0x0000); >> - alc_write_coef_idx(codec, 0x26, 0x0000); >> - alc_write_coef_idx(codec, 0x29, 0x3000); >> - alc_write_coef_idx(codec, 0x37, 0xfe05); >> - alc_write_coef_idx(codec, 0x45, 0x5089); >> + * A certain other OS sets these coeffs to different values. On at least >> + * one TongFang barebone these settings might survive even a cold >> + * reboot. So to restore a clean slate the values are explicitly reset >> + * to default here. Without this, the external microphone is always in a >> + * plugged-in state, while the internal microphone is always in an >> + * unplugged state, breaking the ability to use the internal microphone. >> + */ >> + alc_process_coef_fw(codec, alc256_fixup_tongfang_reset_persistent_settings_coefs); >> } >> >> static const struct coef_fw alc233_fixup_no_audio_jack_coefs[] = { >> -- >> 2.25.1 >>