From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756406AbcHBUqT (ORCPT ); Tue, 2 Aug 2016 16:46:19 -0400 Received: from userp1050.oracle.com ([156.151.31.82]:29397 "EHLO userp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752861AbcHBUqJ (ORCPT ); Tue, 2 Aug 2016 16:46:09 -0400 Subject: Re: [PATCH 1045/1285] Replace numeric parameter like 0444 with macro To: Baole Ni References: <20160802121122.19777-1-baolex.ni@intel.com> Cc: jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chuansheng Liu From: Dave Kleikamp Message-ID: Date: Tue, 2 Aug 2016 13:14:03 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160802121122.19777-1-baolex.ni@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: userp1040.oracle.com [156.151.31.81] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Trimming the cc list.. On 08/02/2016 07:11 AM, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. NACK for the same reasons that others have rejected companion patches. 0644 is much easier to read than S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH. > > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni > --- > fs/jfs/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/jfs/super.c b/fs/jfs/super.c > index cec8814..c348410 100644 > --- a/fs/jfs/super.c > +++ b/fs/jfs/super.c > @@ -67,7 +67,7 @@ struct task_struct *jfsSyncThread; > > #ifdef CONFIG_JFS_DEBUG > int jfsloglevel = JFS_LOGLEVEL_WARN; > -module_param(jfsloglevel, int, 0644); > +module_param(jfsloglevel, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(jfsloglevel, "Specify JFS loglevel (0, 1 or 2)"); > #endif