From: Joerg Vehlow <lkml@jv-coder.de>
To: Steffen Klassert <steffen.klassert@secunet.com>,
Tom Rix <trix@redhat.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] xfrm : lock input tasklet skb queue
Date: Fri, 25 Oct 2019 11:37:59 +0200 [thread overview]
Message-ID: <ad094bfc-ebb3-012b-275b-05fb5a8f86e5@jv-coder.de> (raw)
In-Reply-To: <20191024103134.GD13225@gauss3.secunet.de>
Hi,
I always expected this to be applied to the RT patches. That's why
I originally send my patch to to Sebastian, Thomas and Steven (I added
them again now. The website of the rt patches says patches for the
CONFIG_REEMPT_RT patchset should be send to lkml.
I hope one of the rt patch maintainers will reply here.
Jörg
Am 24.10.2019 um 12:31 schrieb Steffen Klassert:
> On Tue, Oct 22, 2019 at 05:22:04PM -0700, Tom Rix wrote:
>> On PREEMPT_RT_FULL while running netperf, a corruption
>> of the skb queue causes an oops.
>>
>> This appears to be caused by a race condition here
>> __skb_queue_tail(&trans->queue, skb);
>> tasklet_schedule(&trans->tasklet);
>> Where the queue is changed before the tasklet is locked by
>> tasklet_schedule.
>>
>> The fix is to use the skb queue lock.
>>
>> This is the original work of Joerg Vehlow <joerg.vehlow@aox-tech.de>
>> https://lkml.org/lkml/2019/9/9/111
>> xfrm_input: Protect queue with lock
>>
>> During the skb_queue_splice_init the tasklet could have been preempted
>> and __skb_queue_tail called, which led to an inconsistent queue.
>>
>> ifdefs for CONFIG_PREEMPT_RT_FULL added to reduce runtime effects
>> on the normal kernel.
> Has Herbert commented on your initial patch, please
> fix PREEMPT_RT_FULL instead. There are certainly many
> more codepaths that take such assumptions. You can not
> fix this by distributing a spin_lock_irqsave here
> and there.
>
next prev parent reply other threads:[~2019-10-25 9:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 0:22 [PATCH v2 1/1] xfrm : lock input tasklet skb queue Tom Rix
2019-10-24 10:31 ` Steffen Klassert
2019-10-25 9:37 ` Joerg Vehlow [this message]
2019-10-25 9:47 ` Sebastian Andrzej Siewior
2019-10-25 10:14 ` Joerg Vehlow
2019-10-25 10:22 ` Sebastian Andrzej Siewior
2019-10-25 14:26 ` Tom Rix
2019-10-25 19:25 ` Sebastian Andrzej Siewior
2019-10-28 10:44 ` Joerg Vehlow
2019-10-28 15:15 ` Sebastian Andrzej Siewior
2019-10-29 7:33 ` Joerg Vehlow
2019-11-18 10:46 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad094bfc-ebb3-012b-275b-05fb5a8f86e5@jv-coder.de \
--to=lkml@jv-coder.de \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=steffen.klassert@secunet.com \
--cc=tglx@linutronix.de \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).