* [PATCH -next] net/mlx4_core: Add missing iounmap() in error path
@ 2020-04-24 13:53 Zou Wei
2020-04-24 19:48 ` Saeed Mahameed
2020-04-26 3:44 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Zou Wei @ 2020-04-24 13:53 UTC (permalink / raw)
To: tariqt; +Cc: netdev, linux-rdma, linux-kernel, Zou Wei
This fixes the following coccicheck warning:
drivers/net/ethernet/mellanox/mlx4/crdump.c:200:2-8: ERROR: missing iounmap;
ioremap on line 190 and execution via conditional on line 198
Fixes: 7ef19d3b1d5e ("devlink: report error once U32_MAX snapshot ids have been used")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/net/ethernet/mellanox/mlx4/crdump.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mellanox/mlx4/crdump.c b/drivers/net/ethernet/mellanox/mlx4/crdump.c
index 73eae80e..ac5468b 100644
--- a/drivers/net/ethernet/mellanox/mlx4/crdump.c
+++ b/drivers/net/ethernet/mellanox/mlx4/crdump.c
@@ -197,6 +197,7 @@ int mlx4_crdump_collect(struct mlx4_dev *dev)
err = devlink_region_snapshot_id_get(devlink, &id);
if (err) {
mlx4_err(dev, "crdump: devlink get snapshot id err %d\n", err);
+ iounmap(cr_space);
return err;
}
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] net/mlx4_core: Add missing iounmap() in error path
2020-04-24 13:53 [PATCH -next] net/mlx4_core: Add missing iounmap() in error path Zou Wei
@ 2020-04-24 19:48 ` Saeed Mahameed
2020-04-26 3:44 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Saeed Mahameed @ 2020-04-24 19:48 UTC (permalink / raw)
To: zou_wei, Tariq Toukan; +Cc: netdev, linux-rdma, linux-kernel
On Fri, 2020-04-24 at 21:53 +0800, Zou Wei wrote:
> This fixes the following coccicheck warning:
>
> drivers/net/ethernet/mellanox/mlx4/crdump.c:200:2-8: ERROR: missing
> iounmap;
> ioremap on line 190 and execution via conditional on line 198
>
> Fixes: 7ef19d3b1d5e ("devlink: report error once U32_MAX snapshot ids
> have been used")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> drivers/net/ethernet/mellanox/mlx4/crdump.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/crdump.c
> b/drivers/net/ethernet/mellanox/mlx4/crdump.c
> index 73eae80e..ac5468b 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/crdump.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/crdump.c
> @@ -197,6 +197,7 @@ int mlx4_crdump_collect(struct mlx4_dev *dev)
> err = devlink_region_snapshot_id_get(devlink, &id);
> if (err) {
> mlx4_err(dev, "crdump: devlink get snapshot id err
> %d\n", err);
> + iounmap(cr_space);
> return err;
> }
>
Reviewed-by: Saeed Mahameed <saeedm@mellanox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] net/mlx4_core: Add missing iounmap() in error path
2020-04-24 13:53 [PATCH -next] net/mlx4_core: Add missing iounmap() in error path Zou Wei
2020-04-24 19:48 ` Saeed Mahameed
@ 2020-04-26 3:44 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-04-26 3:44 UTC (permalink / raw)
To: zou_wei; +Cc: tariqt, netdev, linux-rdma, linux-kernel
From: Zou Wei <zou_wei@huawei.com>
Date: Fri, 24 Apr 2020 21:53:14 +0800
> This fixes the following coccicheck warning:
>
> drivers/net/ethernet/mellanox/mlx4/crdump.c:200:2-8: ERROR: missing iounmap;
> ioremap on line 190 and execution via conditional on line 198
>
> Fixes: 7ef19d3b1d5e ("devlink: report error once U32_MAX snapshot ids have been used")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-26 3:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-24 13:53 [PATCH -next] net/mlx4_core: Add missing iounmap() in error path Zou Wei
2020-04-24 19:48 ` Saeed Mahameed
2020-04-26 3:44 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).