From: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
To: Dinh Nguyen <dinguyen@kernel.org>, Marek Vasut <marex@denx.de>
Cc: devicetree@vger.kernel.org, linux-fpga@vger.kernel.org,
linux-kernel@vger.kernel.org, Moritz Fischer <mdf@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Alan Tull <atull@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: socfpga: fix base address of SDR controller
Date: Wed, 30 Jan 2019 17:28:04 +0100 [thread overview]
Message-ID: <ad197fef-e946-1861-5ace-f4e8e4f1c044@gmail.com> (raw)
In-Reply-To: <961ac9bf-d111-2e42-a39b-b26c499afcc0@kernel.org>
Am 30.01.2019 um 16:50 schrieb Dinh Nguyen:
>
>
> On 1/30/19 12:00 AM, Simon Goldschmidt wrote:
>> + Marek (as I really want to keep the dts in Linux and U-Boot in sync)
>> On Wed, Jan 30, 2019 at 1:16 AM Dinh Nguyen <dinguyen@kernel.org> wrote:
>>>
>>>
>>>
>>> On 1/29/19 2:08 PM, Simon Goldschmidt wrote:
>>>> From: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
>>>>
>>>> The documentation for socfpga gen5 says the base address of the sdram
>>>> controller is 0xffc20000, while the current devicetree says it is at
>>>> 0xffc25000.
>>>>
>>>> While this is not a problem for Linux, as it only accesses the registers
>>>> above 0xffc25000, it *is* a problem for U-Boot because the lower registers
>>>> are used during DDR calibration (up to now, the U-Boot driver does not use
>>>> the dts address, but that should change).
>>>>
>>>> To keep Linux and U-Boot devicetrees in sync, this patch changes the base
>>>> address to 0xffc20000 and adapts the 2 files where it is currently used.
>>>>
>>>> This patch changes the dts and 2 drivers with one commit to prevent
>>>> breaking the code if dts change and driver change would be split.
>>>>
>>>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
>>>> ---
>>>>
>>>> arch/arm/boot/dts/socfpga.dtsi | 4 ++--
>>>> arch/arm/mach-socfpga/self-refresh.S | 4 ++--
>>>> drivers/fpga/altera-fpga2sdram.c | 2 +-
>>>> 3 files changed, 5 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
>>>> index f365003f0..8f6c1a5d6 100644
>>>> --- a/arch/arm/boot/dts/socfpga.dtsi
>>>> +++ b/arch/arm/boot/dts/socfpga.dtsi
>>>> @@ -788,9 +788,9 @@
>>>> reg = <0xfffec000 0x100>;
>>>> };
>>>>
>>>> - sdr: sdr@ffc25000 {
>>>> + sdr: sdr@ffc20000 {
>>>> compatible = "altr,sdr-ctl", "syscon";
>>>> - reg = <0xffc25000 0x1000>;
>>>> + reg = <0xffc20000 0x6000>;
>>>
>>> I don't see the U-Boot device tree having this change. Yes, the
>>> documentation does state that the SDR address starts at 0xffc20000, but
>>> all of the pertinent registers start at 0x5000 offset. Thus, the
>>> starting address should be 0xffc25000.[1]
>>
>> You don't see it in U-Boot as I'm working on a patch for that.
>> As I wrote in the commit message, U-Boot currently does not use the
>> devicetree for the SDR driver, but I want to convert it to do that.
>
> That's great! Can you elaborate on what is the impetus for converting
> the SDR driver to use the dts?
The initial reason to do so was to move its reset handling from U-Boot
SPL to the driver itself. Moving from ad-hoc code to using the reset driver.
And when it's being converted to using the reset handle from dts, I
think it should also use the base address from dts.
Regards,
Simon
next prev parent reply other threads:[~2019-01-30 16:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 20:08 [PATCH] ARM: socfpga: fix base address of SDR controller Simon Goldschmidt
2019-01-29 22:30 ` Alan Tull
2019-01-30 6:08 ` Simon Goldschmidt
2019-01-30 0:16 ` Dinh Nguyen
2019-01-30 6:00 ` Simon Goldschmidt
2019-01-30 15:50 ` Dinh Nguyen
2019-01-30 16:28 ` Simon Goldschmidt [this message]
2019-02-01 15:13 ` Dinh Nguyen
2019-02-01 15:50 ` Simon Goldschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad197fef-e946-1861-5ace-f4e8e4f1c044@gmail.com \
--to=simon.k.r.goldschmidt@gmail.com \
--cc=atull@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marex@denx.de \
--cc=mark.rutland@arm.com \
--cc=mdf@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).