From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1762655AbcINRkn (ORCPT <rfc822;w@1wt.eu>);
        Wed, 14 Sep 2016 13:40:43 -0400
Received: from mout.web.de ([212.227.15.4]:49351 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755671AbcINRkl (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 14 Sep 2016 13:40:41 -0400
Subject: Re: perf/x86: Use kmalloc_array() in merge_attr()
To: Peter Zijlstra <peterz@infradead.org>
References: <daf81ea8-21bc-d5d0-11af-8957216ae323@users.sourceforge.net>
 <20160905075149.GQ10153@twins.programming.kicks-ass.net>
 <a465479e-59eb-b047-dbe6-f3686b4ecd31@users.sourceforge.net>
 <20160914170452.GD5016@twins.programming.kicks-ass.net>
Cc: x86@kernel.org,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <ad27a3a5-87de-b234-fb4a-2f3ab8bbcbc2@users.sourceforge.net>
Date: Wed, 14 Sep 2016 19:38:15 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <20160914170452.GD5016@twins.programming.kicks-ass.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:a2i8bbm0G9QyntzxU1G6kRQxlgbfGzfkZBJY0zNJTsX2QddAX2N
 VSk8OnTmYZmv4+u3gqJXo1Xcxba9+JklHJFlsElugLv4NtZWuYHUVKjTRmtML3PIaQ4aDEI
 bzLOvwOowAbqdjRyWoYKI1S2umMjPIT1ra/cRI1t/rEOgDK7f0/ISjZpqvggLBXFZGwxlZY
 N803pI/M3ocadDqNvghoQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:YeR/IflM7Bs=:yvi49V3OdpRwtm1/B7uco5
 iLL77jP6bsOFrMnR5XgQ8dxJzhTiIAJWtnKwC0azuW6mCreMfmDI9Fk4Da4fEWWukf4rO4oQD
 1JcDbM5LbW+9wqlF213Q3dvC92Ou8QlvfcLU6Y46N1okDrD4jeTchGan7AAsfNRbUssoFGrcm
 sgVOANh5U20WiiRC8bagJGDAqxCaQ6j6O1ZaNvZnNRKNj98gO6azuw/albU/fSQxLtJG6fXaJ
 BMNupuGL9Q5NWD6u82pRKJ7kZL//4z78M+AVXvlpKbkNYS/iqbl2dr0G9Zshj3rIUgrGZuyA4
 CgmTjtsBWEqU434wkPcjLWJ/j++SZwe9OtzLajufl7YlH+Ti4WRTXGOhLtY5m0VKtjbNR09Rn
 TUyFr4G7hyjAavX+xFqLKD4rvRMtjUoK/Ini58MSOBuoW8uWqDB9/r9dKLDajWZ9W264B6wZS
 MephnwUkZLfAk+kfEdTtmQb+oq0je/JX2LYqeUXbUTQCvi3F+xtiaiXq8x6FMLAsbT+IVjBAp
 dmn7wYSRR5J05fJ8PoKOdnOmyngWlHXl5nUcXiEz25W3EyrbhChYVHIfjwenYDZFEiibIQMCr
 PKVzlKNna3cDfCQb6ZslDhHbtWAYOi1cSDz44by3vv7HxKwKOxDtJATzor6m1yC1dmBVUu5NK
 pPiIVjV+QvXw5Gq/P1eB5xzfuPbi37OWnXj76qJQ0+P+1kIs33LSYaSi0UMcl1Fr1I4LQdpkG
 yiHtPeqEuMd0aZdBN+IK3D2y1dyTPf7J36/uhAsbCP31b7ItLx6AxiAqMbhtZFLy+Lk2eY1AA
 tIPb2Js
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> Would you like to suggest any more constraints for this kind of
>> software refactoring?
> 
> Yes, don't do it.

I am bit surprised by this feedback.


> If you're writing new code by all means, do whatever you feel,

Could you accept related software updates then?


> but don't go changing code just because checkpatch.

Why is this not a valid reason for you?

How useful can properties that are provided by a function like
kmalloc_array() be also for software modules which you care about?


Do you find any other software improvements more worthwhile?

Regards,
Markus