linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sven Schwermer <sven@svenschwermer.de>
To: "Bjørn Mork" <bjorn@mork.no>, "Lars Melin" <larsm17@gmail.com>
Cc: linux-usb@vger.kernel.org,
	Sven Schwermer <sven.schwermer@disruptive-technologies.com>,
	linux-kernel@vger.kernel.org, oliver@neukum.org
Subject: Re: [PATCH v1 2/2] net: usb: cdc_ether: Add Fibocom MA510 modem
Date: Fri, 8 Apr 2022 20:54:34 +0200	[thread overview]
Message-ID: <ad3720df-73d4-5463-a538-d921cdf9f0b3@svenschwermer.de> (raw)
In-Reply-To: <87ee27y9ym.fsf@miraculix.mork.no>

Hi Lars,

On 4/8/22 15:35, Bjørn Mork wrote:
> Lars Melin <larsm17@gmail.com> writes:
> 
>> Why do you add this modem to the whitelist?
> 
> I believe the clue is the
> 
>> +	.driver_info = (unsigned long)&wwan_info,
> 
> to set FLAG_WWAN instead of the default FLAG_ETHER | FLAG_POINTTOPOINT

Bjørn is right that this is the reason. The Fibocom MA510 and L610 are 
cellular modems, so they require to be labelled as WWAN devices. As such 
they require to be set up (using AT commands or similar) before the 
connection can be used. Furthermore, WWAN devices get a different 
routing metric assigned by the network manager than regular Ethernet 
devices.

>> The net interface has the correct cdc_ether attributes so the
>> cdc_ether driver should bind automagically without any need for the
>> modem to be in the whitelist.
> 
> Yes, this sort of works against the class driver philosophy.  But we've
> already started down that road, so...
> 
> 
> 
> Bjørn

  reply	other threads:[~2022-04-08 18:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07  7:47 [PATCH v1 1/2] net: usb: cdc_ether: Add Fibocom L610 modem sven
2022-04-07  7:47 ` [PATCH v1 2/2] net: usb: cdc_ether: Add Fibocom MA510 modem sven
2022-04-08  1:15   ` Lars Melin
2022-04-08 13:35     ` Bjørn Mork
2022-04-08 18:54       ` Sven Schwermer [this message]
2022-04-08  1:23 ` [PATCH v1 1/2] net: usb: cdc_ether: Add Fibocom L610 modem Lars Melin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad3720df-73d4-5463-a538-d921cdf9f0b3@svenschwermer.de \
    --to=sven@svenschwermer.de \
    --cc=bjorn@mork.no \
    --cc=larsm17@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oliver@neukum.org \
    --cc=sven.schwermer@disruptive-technologies.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).