From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Stanley Chu <stanley.chu@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh+dt@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org, wsd_upstream@mediatek.com
Subject: Re: [PATCH 1/2] dt-bindings: Add mtk-systimer bindings
Date: Mon, 25 Jun 2018 23:53:45 +0200 [thread overview]
Message-ID: <ad38a952-4400-984a-a7fd-aa4e6af13c13@linaro.org> (raw)
In-Reply-To: <1529910601-15005-2-git-send-email-stanley.chu@mediatek.com>
On 25/06/2018 09:10, Stanley Chu wrote:
> Add binding documentation for the System Timer driver of
> the Mediatek SoCs.
>
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> ---
> .../bindings/timer/mediatek,mtk-systimer.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/timer/mediatek,mtk-systimer.txt
>
> diff --git a/Documentation/devicetree/bindings/timer/mediatek,mtk-systimer.txt b/Documentation/devicetree/bindings/timer/mediatek,mtk-systimer.txt
> new file mode 100644
> index 0000000..735a6fd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/mediatek,mtk-systimer.txt
> @@ -0,0 +1,18 @@
> +Mediatek System Timers
> +----------------------
> +
> +Required properties:
> +- compatible: should contain
> + "mediatek,sys_timer" for those platforms which support system timer.
> +- reg: Mandatory. The location and length for system timer registers.
> +- clock-frequency: Optional. If not assigned specifically, default
> + value 13000000 (means 13 MHz) would be applied.
The driver tells there is an error if it is not defined, so it can't be
optional.
> +Examples:
> +
> + sys_timer@10017000 {
> + compatible = "mediatek,sys_timer";
> + reg = <0 0x10017000 0 0x1000>;
> + interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_HIGH>;
> + clock-frequency = <13000000>;
Replace it by a phandle to a 'fixed-clock'.
eg.
clocks = <&myclk>;
> + };
myclk: myclk {
#clock-cells = <0>;
compatible = "fixed-clock";
clock-frequency = <13000000>;
};
Thanks
-- DAniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2018-06-25 21:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 7:09 Add system timer driver for Mediatek SoCs Stanley Chu
2018-06-25 7:10 ` [PATCH 1/2] dt-bindings: Add mtk-systimer bindings Stanley Chu
2018-06-25 21:53 ` Daniel Lezcano [this message]
2018-06-26 6:36 ` Stanley Chu
2018-06-25 7:10 ` [PATCH 2/2] clocksource/drivers/mtk_systimer: Add support for Mediatek SoCs Stanley Chu
2018-06-26 7:41 ` Daniel Lezcano
2018-06-26 9:52 ` Stanley Chu
2018-06-25 7:34 ` Add system timer driver " Daniel Lezcano
2018-06-25 9:07 ` Stanley Chu
2018-06-26 7:31 ` Daniel Lezcano
2018-06-26 8:03 ` Stanley Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad38a952-4400-984a-a7fd-aa4e6af13c13@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=stanley.chu@mediatek.com \
--cc=tglx@linutronix.de \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).