From: Kamil Konieczny <k.konieczny@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Vladimir Zapolskiy <vz@mleia.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
linux-crypto@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] crypto: s5p-sss - Add and fix kerneldoc
Date: Fri, 4 Sep 2020 11:07:05 +0200 [thread overview]
Message-ID: <ad460c31-aa10-21a8-2fd9-698d5a7ca823@samsung.com> (raw)
In-Reply-To: <20200903180400.2865-2-krzk@kernel.org>
On 9/3/20 8:03 PM, Krzysztof Kozlowski wrote:
> Add missing and fix existing kerneldoc to silence W=1 warnings:
>
> drivers/crypto/s5p-sss.c:333: warning: Function parameter or member 'pclk' not described in 's5p_aes_dev'
> drivers/crypto/s5p-sss.c:373: warning: Function parameter or member 'sgl' not described in 's5p_hash_reqctx'
> drivers/crypto/s5p-sss.c:373: warning: Function parameter or member 'buffer' not described in 's5p_hash_reqctx'
> drivers/crypto/s5p-sss.c:1143: warning: Function parameter or member 'new_len' not described in 's5p_hash_prepare_sgs'
> drivers/crypto/s5p-sss.c:1143: warning: Excess function parameter 'nbytes' description in 's5p_hash_prepare_sgs'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/crypto/s5p-sss.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> index 341433fbcc4a..f67f1e22ecd1 100644
> --- a/drivers/crypto/s5p-sss.c
> +++ b/drivers/crypto/s5p-sss.c
> @@ -260,6 +260,7 @@ struct s5p_aes_ctx {
> * struct s5p_aes_dev - Crypto device state container
> * @dev: Associated device
> * @clk: Clock for accessing hardware
> + * @pclk: APB bus clock necessary to access the hardware
> * @ioaddr: Mapped IO memory region
> * @aes_ioaddr: Per-varian offset for AES block IO memory
> * @irq_fc: Feed control interrupt line
> @@ -342,13 +343,13 @@ struct s5p_aes_dev {
> * @engine: Bits for selecting type of HASH in SSS block
> * @sg: sg for DMA transfer
> * @sg_len: Length of sg for DMA transfer
> - * @sgl[]: sg for joining buffer and req->src scatterlist
> + * @sgl: sg for joining buffer and req->src scatterlist
> * @skip: Skip offset in req->src for current op
> * @total: Total number of bytes for current request
> * @finup: Keep state for finup or final.
> * @error: Keep track of error.
> * @bufcnt: Number of bytes holded in buffer[]
> - * @buffer[]: For byte(s) from end of req->src in UPDATE op
> + * @buffer: For byte(s) from end of req->src in UPDATE op
> */
> struct s5p_hash_reqctx {
> struct s5p_aes_dev *dd;
> @@ -1125,7 +1126,7 @@ static int s5p_hash_copy_sg_lists(struct s5p_hash_reqctx *ctx,
> * s5p_hash_prepare_sgs() - prepare sg for processing
> * @ctx: request context
> * @sg: source scatterlist request
> - * @nbytes: number of bytes to process from sg
> + * @new_len: number of bytes to process from sg
> * @final: final flag
> *
> * Check two conditions: (1) if buffers in sg have len aligned data, and (2)
>
Reviewed-by: Kamil Konieczny <k.konieczny@samsung.com>
Acked-by: Kamil Konieczny <k.konieczny@samsung.com>
next prev parent reply other threads:[~2020-09-04 9:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200903180412eucas1p10d854b51ba650b27265f088b07c93b15@eucas1p1.samsung.com>
2020-09-03 18:03 ` [PATCH 1/3] dt-bindings: crypto: slimsss: Correct a typo in compatible Krzysztof Kozlowski
2020-09-03 18:03 ` [PATCH 2/3] crypto: s5p-sss - Add and fix kerneldoc Krzysztof Kozlowski
2020-09-04 9:07 ` Kamil Konieczny [this message]
2020-09-11 6:59 ` Herbert Xu
2020-09-03 18:04 ` [PATCH 3/3] crypto: s5p-sss - Pass error from clk_get and reduce verbosity on deferral Krzysztof Kozlowski
2020-09-04 9:06 ` Kamil Konieczny
2020-09-11 6:59 ` Herbert Xu
2020-09-04 9:07 ` [PATCH 1/3] dt-bindings: crypto: slimsss: Correct a typo in compatible Kamil Konieczny
2020-09-04 9:17 ` Krzysztof Kozlowski
2020-09-14 20:34 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad460c31-aa10-21a8-2fd9-698d5a7ca823@samsung.com \
--to=k.konieczny@samsung.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=krzk@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).