From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] io_uring: optimise sqe-to-req flags translation
Date: Sat, 18 Jan 2020 20:10:30 +0300 [thread overview]
Message-ID: <ad7c75c3-b660-9814-e3fe-ef5a3acd7e8f@gmail.com> (raw)
In-Reply-To: <b773df2f-8873-77f3-d25d-b59c66f3a04b@kernel.dk>
[-- Attachment #1.1: Type: text/plain, Size: 619 bytes --]
On 18/01/2020 19:34, Jens Axboe wrote:
>> +enum {
>> + /* correspond one-to-one to IOSQE_IO_* flags*/
>> + REQ_F_FIXED_FILE = BIT(REQ_F_FIXED_FILE_BIT), /* ctx owns file */
>
> I'd put the comment on top of the line instead, these lines are way too
> long.
I find it less readable, but let's see
>
> Let's please not use BIT() for the user visible part, though. And I'd
> leave these as defines, sometimes apps do things ala:
>
> #ifndef IOSQE_IO_LINK
> #define IOSQE_IO_LINK ...
> #endif
>
> to make it easier to co-exist with old and new headers.
>Yeah, good point!
--
Pavel Begunkov
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-01-18 17:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 22:22 [PATCH 1/2] io_uring: remove REQ_F_IO_DRAINED Pavel Begunkov
2020-01-17 22:22 ` [PATCH 2/2] io_uring: optimise sqe-to-req flags translation Pavel Begunkov
2020-01-17 22:41 ` [PATCH 0/2] optimise sqe-to-req flags Pavel Begunkov
2020-01-17 22:49 ` Jens Axboe
2020-01-17 23:14 ` Pavel Begunkov
2020-01-18 0:16 ` Jens Axboe
2020-01-18 10:24 ` [PATCH v2] io_uring: optimise sqe-to-req flags translation Pavel Begunkov
2020-01-18 16:34 ` Jens Axboe
2020-01-18 17:10 ` Pavel Begunkov [this message]
2020-01-18 17:22 ` [PATCH v3 1/1] " Pavel Begunkov
2020-01-18 20:46 ` Jens Axboe
2020-01-19 7:46 ` Pavel Begunkov
2020-01-19 17:36 ` Jens Axboe
2020-01-18 20:45 ` [PATCH v2] " Jens Axboe
2020-01-17 22:50 ` [PATCH 1/2] io_uring: remove REQ_F_IO_DRAINED Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad7c75c3-b660-9814-e3fe-ef5a3acd7e8f@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).