From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 162D6C433EF for ; Thu, 14 Apr 2022 18:26:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344539AbiDNS3V (ORCPT ); Thu, 14 Apr 2022 14:29:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232933AbiDNS3L (ORCPT ); Thu, 14 Apr 2022 14:29:11 -0400 Received: from mxout02.lancloud.ru (mxout02.lancloud.ru [45.84.86.82]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D19F2E38B9; Thu, 14 Apr 2022 11:26:43 -0700 (PDT) Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout02.lancloud.ru DFC32233D6F3 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH V2] clk: renesas: Fix memory leak of 'cpg' To: Geert Uytterhoeven CC: Haowen Bai , Michael Turquette , Stephen Boyd , Linux-Renesas , linux-clk , Linux Kernel Mailing List References: <1649837953-10984-1-git-send-email-baihaowen@meizu.com> <2ed01eb3-ff46-425c-75dc-81729a5c30a8@omp.ru> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Thu, 14 Apr 2022 21:26:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT01.lancloud.ru (fd00:f066::141) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/14/22 12:32 PM, Geert Uytterhoeven wrote: [...] >>> Fix this issue by freeing the cpg when exiting the function in the >>> error/normal path. >>> >>> Signed-off-by: Haowen Bai >>> --- >>> V1->V2: free both cpg&clks. >>> >>> drivers/clk/renesas/clk-r8a73a4.c | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> 2 patches with the same name won't do -- you always need to include the chip name >> part of the file name in the subject (in this case r8a73a4). > > Oh, they were for multiple drivers? I counted 3! :-) > I hadn't even noticed , as Gmail collapsed them all into the same thread... Hm, they weren't actually posted in the same thread... > Gr{oetje,eeting}s, > > Geert [...] MBR, Sergey