From: Roland Dreier <rdreier@cisco.com>
To: Grant Grundler <grundler@parisc-linux.org>
Cc: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
Andrew Morton <akpm@osdl.org>, Greg KH <greg@kroah.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH 0/4] PCI legacy I/O port free driver (take4)
Date: Thu, 02 Mar 2006 11:50:59 -0800 [thread overview]
Message-ID: <adalkvswrq4.fsf@cisco.com> (raw)
In-Reply-To: <20060302193441.GG28895@flint.arm.linux.org.uk> (Russell King's message of "Thu, 2 Mar 2006 19:34:41 +0000")
Russell> Why isn't pci_enable_device_bars() sufficient - why do we
Russell> have to have another interface to say "we don't want BARs
Russell> XXX" ?
That's an excellent point. It does look like fixing
pci_enable_device_bars() would be a reasonable interface as well.
Currently, pci_enable_device() calls pci_enable_device_bars() on all
resources, and then does two more things:
- It calls pci_fixup_device() on the device
- It sets dev->is_enabled
Both of these things look like they could just be moved into
pci_enable_device_bars(), leaving pci_enable_device() as a
compatibility wrapper.
Along with a fix for pci_request_regions(), the legacy-free patch
would just modify drivers for devices that know they don't need a
particular BAR, without adding an extra flag to the pci device struct.
- R.
next prev parent reply other threads:[~2006-03-02 19:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-02 15:12 [PATCH 0/4] PCI legacy I/O port free driver (take4) Kenji Kaneshige
2006-03-02 15:14 ` [PATCH 1/4] PCI legacy I/O port free driver (take4) - Add no_ioport flag into pci_dev Kenji Kaneshige
2006-03-02 15:16 ` [PATCH 2/4] PCI legacy I/O port free driver (take4) - Update Documentation/pci.txt Kenji Kaneshige
2006-03-02 15:18 ` [PATCH 3/4] PCI legacy I/O port free driver (take4) - Make Intel e1000 driver legacy I/O port free Kenji Kaneshige
2006-03-02 15:20 ` [PATCH 4/4] PCI legacy I/O port free driver (take4) - Make Emulex lpfc " Kenji Kaneshige
2006-03-02 15:50 ` [PATCH 0/4] PCI legacy I/O port free driver (take4) Russell King
2006-03-02 16:23 ` Kenji Kaneshige
2006-03-02 16:41 ` Greg KH
2006-03-02 17:24 ` Grant Grundler
2006-03-02 18:00 ` Russell King
2006-03-02 18:12 ` Jeff Garzik
2006-03-02 19:13 ` Russell King
2006-03-02 20:01 ` Jeff Garzik
2006-03-02 19:23 ` Grant Grundler
2006-03-02 19:34 ` Russell King
2006-03-02 19:50 ` Roland Dreier [this message]
2006-03-03 3:17 ` Kenji Kaneshige
2006-03-03 6:59 ` Kenji Kaneshige
2006-03-06 1:38 ` Kenji Kaneshige
2006-03-10 2:10 ` Adam Belay
2006-03-10 4:10 ` Kenji Kaneshige
2006-03-10 7:49 ` Russell King
2006-03-10 8:33 ` Russell King
2006-03-13 5:47 ` Kenji Kaneshige
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adalkvswrq4.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=grundler@parisc-linux.org \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).