From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756997Ab0CJURI (ORCPT ); Wed, 10 Mar 2010 15:17:08 -0500 Received: from sj-iport-6.cisco.com ([171.71.176.117]:54918 "EHLO sj-iport-6.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756976Ab0CJURG (ORCPT ); Wed, 10 Mar 2010 15:17:06 -0500 Authentication-Results: sj-iport-6.cisco.com; dkim=neutral (message not signed) header.i=none X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAAuNl0urR7Hu/2dsb2JhbACaVHOjUZhThHkEgxc X-IronPort-AV: E=Sophos;i="4.49,616,1262563200"; d="scan'208";a="494790090" From: Roland Dreier To: Robert Hancock Cc: linux-kernel , netdev , Linux-usb , David Miller , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH RFC] fix problems with NETIF_F_HIGHDMA in networking drivers v2 References: <4B8F213B.40603@gmail.com> X-Message-Flag: Warning: May contain useful information Date: Wed, 10 Mar 2010 12:17:00 -0800 In-Reply-To: <4B8F213B.40603@gmail.com> (Robert Hancock's message of "Wed, 03 Mar 2010 20:55:55 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c > index df3eb8c..53be462 100644 > --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c > +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c > @@ -1058,7 +1058,7 @@ static void ipoib_setup(struct net_device *dev) > dev->type = ARPHRD_INFINIBAND; > dev->tx_queue_len = ipoib_sendq_size * 2; > dev->features = (NETIF_F_VLAN_CHALLENGED | > - NETIF_F_HIGHDMA); > + NETIF_F_DMA_HIGH); > dev->priv_flags &= ~IFF_XMIT_DST_RELEASE; > > memcpy(dev->broadcast, ipv4_bcast_addr, INFINIBAND_ALEN); Been meaning to mention this for a bit, but ipoib is capable of handling any DMA address, so if I understand your patch correctly, this can be NETIF_F_DMA_64BIT instead of just DMA_HIGH. -- Roland Dreier For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html