From: Roland Dreier <rdreier@cisco.com>
To: Or Gerlitz <ogerlitz@voltaire.com>
Cc: linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: Re: [openib-general] [PATCH 6/6] iSER Kconfig and Makefile
Date: Thu, 11 May 2006 10:24:51 -0700 [thread overview]
Message-ID: <adau07w1nks.fsf@cisco.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0605111003160.18975-100000@zuben> (Or Gerlitz's message of "Thu, 11 May 2006 10:03:30 +0300 (IDT)")
I fixed up this patch so that it actually hooks into the build (as
below). (BTW, when sending patches in the future, please make them
apply with "-p1" -- your patches had paths like
/usr/src/linux-2.6.17-rc3/drivers/infiniband/ulp/iser-x/Kconfig
so I had to manually strip off the /usr/src/)
Anyway, with a config like
CONFIG_SCSI_ISCSI_ATTRS=y
# CONFIG_ISCSI_TCP is not set
CONFIG_INFINIBAND_ISER=y
My build fails with a bunch of errors like:
drivers/built-in.o: In function `iser_comp_error_worker':iser_verbs.c:(.text+0x7d7cd): undefined reference to `iscsi_conn_failure'
and so on. Is the correct fix for this to add
obj-$(CONFIG_INFINIBAND_ISER) += libiscsi.o
to drivers/scsi/Makefile?
Also, I get the following sparse warning:
drivers/infiniband/ulp/iser/iser_initiator.c:610:25: error: incompatible types for operation (&)
and the code there does look fishy:
itt = hdr->itt & ISCSI_ITT_MASK; /* mask out cid and age bits */
hdr->itt is __be32 but ISCSI_ITT_MASK is just (0xfff), so it seems
that there is something wrong, either with the iSCSI endianness
annotation or with the code itself.
Thanks,
Roland
---
diff-tree 9120bc6c8b5bdd1f4c85df7a04779ae8faa0c1a5 (from 4161cba09429dae06d249584ee1c7d63c672422c)
Author: Or Gerlitz <ogerlitz@voltaire.com>
Date: Thu May 11 10:03:30 2006 +0300
IB/iser: iSER Kconfig and Makefile
Kconfig and Makefile for iSER.
Signed-off-by: Or Gerlitz <ogerlitz@voltaire.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
index ba2d650..69a53d4 100644
--- a/drivers/infiniband/Kconfig
+++ b/drivers/infiniband/Kconfig
@@ -41,4 +41,6 @@ source "drivers/infiniband/ulp/ipoib/Kco
source "drivers/infiniband/ulp/srp/Kconfig"
+source "drivers/infiniband/ulp/iser/Kconfig"
+
endmenu
diff --git a/drivers/infiniband/Makefile b/drivers/infiniband/Makefile
index eea2732..abeaf79 100644
--- a/drivers/infiniband/Makefile
+++ b/drivers/infiniband/Makefile
@@ -3,3 +3,4 @@ obj-$(CONFIG_INFINIBAND_MTHCA) += hw/mt
obj-$(CONFIG_IPATH_CORE) += hw/ipath/
obj-$(CONFIG_INFINIBAND_IPOIB) += ulp/ipoib/
obj-$(CONFIG_INFINIBAND_SRP) += ulp/srp/
+obj-$(CONFIG_INFINIBAND_SRP) += ulp/iser/
diff --git a/drivers/infiniband/ulp/iser/Kconfig b/drivers/infiniband/ulp/iser/Kconfig
new file mode 100644
index 0000000..fead87d
--- /dev/null
+++ b/drivers/infiniband/ulp/iser/Kconfig
@@ -0,0 +1,11 @@
+config INFINIBAND_ISER
+ tristate "ISCSI RDMA Protocol"
+ depends on INFINIBAND && SCSI
+ select SCSI_ISCSI_ATTRS
+ ---help---
+ Support for the ISCSI RDMA Protocol over InfiniBand. This
+ allows you to access storage devices that speak ISER/ISCSI
+ over InfiniBand.
+
+ The ISER protocol is defined by IETF.
+ See <http://www.ietf.org/>.
diff --git a/drivers/infiniband/ulp/iser/Makefile b/drivers/infiniband/ulp/iser/Makefile
new file mode 100644
index 0000000..fe6cd15
--- /dev/null
+++ b/drivers/infiniband/ulp/iser/Makefile
@@ -0,0 +1,4 @@
+obj-$(CONFIG_INFINIBAND_ISER) += ib_iser.o
+
+ib_iser-y := iser_verbs.o iser_initiator.o iser_memory.o \
+ iscsi_iser.o
next prev parent reply other threads:[~2006-05-11 17:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-11 6:59 [PATCH 0/6] iSER (iSCSI Extensions for RDMA) initiator Or Gerlitz
2006-05-11 7:00 ` [PATCH 1/6] iSCSI iSER transport provider header file Or Gerlitz
2006-05-11 7:00 ` [PATCH 2/6] iSCSI iSER transport provider high level code Or Gerlitz
2006-05-11 7:02 ` [PATCH 3/6] iSER initiator iSCSI PDU and TX/RX completions processing Or Gerlitz
2006-05-11 7:02 ` [PATCH 4/6] iSER RDMA CM (CMA) and IB verbs interaction Or Gerlitz
2006-05-11 7:03 ` [PATCH 5/6] iSER handling of memory for RDMA Or Gerlitz
2006-05-11 7:03 ` [PATCH 6/6] iSER Kconfig and Makefile Or Gerlitz
2006-05-11 17:24 ` Roland Dreier [this message]
2006-05-11 18:24 ` [openib-general] " Or Gerlitz
2006-05-11 18:29 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adau07w1nks.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ogerlitz@voltaire.com \
--cc=openib-general@openib.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).