From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F5FAC43332 for ; Fri, 19 Mar 2021 13:12:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B98264EED for ; Fri, 19 Mar 2021 13:12:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230131AbhCSNMa (ORCPT ); Fri, 19 Mar 2021 09:12:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230025AbhCSNMM (ORCPT ); Fri, 19 Mar 2021 09:12:12 -0400 Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2A8EC061761 for ; Fri, 19 Mar 2021 06:12:11 -0700 (PDT) Received: by mail-qt1-x82d.google.com with SMTP id h7so6612370qtx.3 for ; Fri, 19 Mar 2021 06:12:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8AjV5s8aOfyy3KT30UQRTNY2SjJvqQorjtJI5nyloq0=; b=viUBvBj4Em71xPV7glPu3zcqVMPq5Fq9+oSYKg7PyDkcEj0/YVz717DaCnFuAKmYcK qiiRPnonwcnfVPw4H3+BUn02ZNjOjBH9rC3fRU0v2goMYXbz9h25HVuW2cIGRLBwAc6I AdC8y5kbv/YF18tWCt36jpJVjL22Glj+DCBz6rOmamaz5tCry1As5jhtLy5laj97V2Nd KtjD0WDlsv4FQK96CLezut5GoGdZ8KQd4nSdXmvRLaiY9oNqSA6B/yLsWMrUGogkS1NF xW5+q8b85kL+9B34W27+WN2ai8AKWMJknScnESDEPVBL6qk5PAmBVNuKTeBeQMhPzT6w Isxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8AjV5s8aOfyy3KT30UQRTNY2SjJvqQorjtJI5nyloq0=; b=T/uOq/h3mxWhlTmYkzvoE5jq1xH5LLSMq1qaP7Ugt9oPcl9RqAjS3pCXWqcfE0FRRU pIT8fCm00iRH7g27cjret7d/rvjJucwegm7nPDYTgMCoVOZwwxdNOQUnbaezP9QiCO5a qro3stxXyidzloJAGKZajPpvsJtREQo0ghNa4N/NwU6h7dvqfguxXuwh+30is6PoyqAd lbWNmr/yK9Nmz2Pdp71GaqG2wPAMiYhF9QVa5xCqT7q/3/y4k21cEbydAC4bn8BKEP+B LpcTUyRtEcOwSNmatoGM3gPfvqCNTSOMIFjyndkPxt2F7W8Ao89h+gmzj5/pFkI0QuRx PgqQ== X-Gm-Message-State: AOAM531G6TgG547FqExM7RJYHsYBA9a/HGZ7p9uudRULNGxSQOs03tF7 seeVNjltuKcmE5kHzIdsoh8nrzqi2z5IoA== X-Google-Smtp-Source: ABdhPJzYpwsFI868JfavXgcFuabV0GrhMPLuCnNTWahVJqRLN9HvxCe+LJha08h8v8ANBgwUzpY0ZQ== X-Received: by 2002:aed:206c:: with SMTP id 99mr8365070qta.64.1616159530619; Fri, 19 Mar 2021 06:12:10 -0700 (PDT) Received: from [192.168.1.93] (pool-71-163-245-5.washdc.fios.verizon.net. [71.163.245.5]) by smtp.gmail.com with ESMTPSA id g74sm4225789qke.3.2021.03.19.06.12.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Mar 2021 06:12:10 -0700 (PDT) From: Thara Gopinath Subject: Re: [PATCH v11 6/9] drivers: thermal: tsens: Replace custom 8960 apis with generic apis To: Ansuel Smith Cc: Andy Gross , Bjorn Andersson , Amit Kucheria , Zhang Rui , Daniel Lezcano , Rob Herring , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210319005228.1250-1-ansuelsmth@gmail.com> <20210319005228.1250-7-ansuelsmth@gmail.com> Message-ID: Date: Fri, 19 Mar 2021 09:12:09 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210319005228.1250-7-ansuelsmth@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/18/21 8:52 PM, Ansuel Smith wrote: > Rework calibrate function to use common function. Derive the offset from > a missing hardcoded slope table and the data from the nvmem calib > efuses. > Drop custom get_temp function and use generic api. > > Signed-off-by: Ansuel Smith > Acked-by: Thara Gopinath > --- > drivers/thermal/qcom/tsens-8960.c | 56 +++++++++---------------------- > 1 file changed, 15 insertions(+), 41 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens-8960.c b/drivers/thermal/qcom/tsens-8960.c > index bdc64d4188bf..8c523b764862 100644 > --- a/drivers/thermal/qcom/tsens-8960.c > +++ b/drivers/thermal/qcom/tsens-8960.c > @@ -67,6 +67,13 @@ > #define S9_STATUS_OFF 0x3674 > #define S10_STATUS_OFF 0x3678 > > +/* Original slope - 200 to compensate mC to C inaccuracy */ > +u32 tsens_msm8960_slope[] = { > + 976, 976, 954, 976, > + 911, 932, 932, 999, > + 932, 999, 932 > + }; make -C1 throws a warning for this. You have to make the table static. You can keep my Acked-by once it is fixed. Warm Regards Thara