From: Sibi S <sibis@codeaurora.org> To: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: andy.gross@linaro.org, david.brown@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-soc@vger.kernel.org Subject: Re: [PATCH] arm64: dts: qcom: Add SDM845 SMEM nodes Date: Thu, 26 Apr 2018 19:55:12 +0530 Message-ID: <ade07b7f-4cc6-0a96-85f7-abb5b76ce80e@codeaurora.org> (raw) In-Reply-To: <20180425220626.GM2052@tuxbook-pro> Hi Bjorn, Thanks for the review On 04/26/2018 03:36 AM, Bjorn Andersson wrote: > On Wed 25 Apr 07:46 PDT 2018, Sibi Sankar wrote: >> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi >> index 9be763da0664..bea985045759 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi >> @@ -21,6 +21,27 @@ >> reg = <0 0x80000000 0 0>; >> }; >> >> + reserved-memory { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges; >> + >> + memory@85fc0000 { >> + reg = <0 0x85fc0000 0 0x40000>; > > The region 0x85fe0000 + 0x20000 seems to be command db, which should be > described on its own. So please reduce the size to 0x20000. > >> + no-map; >> + }; >> + >> + smem_mem: smem-mem@86000000 { > > smem_mem: memory@86000000 ? Should I update kernel docs as well to say all nodes should have memory has default name? Just followed what was done in msm8916 and msm8996. > >> + reg = <0x0 0x86000000 0x0 0x200000>; >> + no-map; >> + }; >> + >> + memory@86000000 { > > memory@86200000 > >> + reg = <0 0x86200000 0 0x2d00000>; >> + no-map; >> + }; >> + }; >> + > > The rest looks good. > > Regards, > Bjorn > -- Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc, is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
prev parent reply index Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-25 14:46 Sibi Sankar 2018-04-25 22:06 ` Bjorn Andersson 2018-04-26 14:25 ` Sibi S [this message]
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ade07b7f-4cc6-0a96-85f7-abb5b76ce80e@codeaurora.org \ --to=sibis@codeaurora.org \ --cc=andy.gross@linaro.org \ --cc=bjorn.andersson@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=david.brown@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org public-inbox-index lkml Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/ public-inbox