From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84117C4320A for ; Fri, 20 Aug 2021 12:49:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6710E610CF for ; Fri, 20 Aug 2021 12:49:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240329AbhHTMtp (ORCPT ); Fri, 20 Aug 2021 08:49:45 -0400 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:54842 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231685AbhHTMth (ORCPT ); Fri, 20 Aug 2021 08:49:37 -0400 Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id DCD9F40767 for ; Fri, 20 Aug 2021 12:48:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1629463734; bh=e6+/LPJwCnWwvmlU9AwLblFP9pPUPAQRXF2MXzGKarc=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=IRWeyC9tM8DU0pjZ8OrWJow5DXutX9MwbWU48QGNjqYfXoMoexInKuT5JOjWt4zvN CXO4xW8MHoCr0Mzyx1/yHgQD3R2SFzzQreS79ewNcchGF+BdnnRvVBrh4NEgiJbK+2 QXgOQgdYpm0BYV11CS7gG5Tn8AjVFup+LJMJ5pG4xe3qpCHBPaHHelVUCo2h3m+5HO dHjBKvF/PfNd9ALaKYwJoJ8KlcWQH77IUCOl8LVe7NzPAp090nNEtosq7uP1bjSz/M nMaTMGtmWzQhrNEng95kVeH4pNeaWcffV+wT0erjaHTBPOR7CGn7RvTnvA7abXEo75 +58sjspfTHBEw== Received: by mail-ej1-f72.google.com with SMTP id e15-20020a1709061fcf00b005bd9d618ea0so3655743ejt.13 for ; Fri, 20 Aug 2021 05:48:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=e6+/LPJwCnWwvmlU9AwLblFP9pPUPAQRXF2MXzGKarc=; b=uf8ZsXzfsNtFdRdTI5275DNDrGqaXFa9KmGeQaBUEAmZU6i0aybgkdIf7Lnkmw3UMO 61k0KxivqzFeow9JeXS/8iZapFInHFQ99r8vBXowIgXeMjhCM5ikyqjO6zPknAg15zyE SqLlFCfoZ7e0zCEnixPXWEGN2QmfKIHv8Fss8vYmVXD9m7nwIMryJVrP5iT47PrlPuYQ QSw5IaJO2Cx2wzyZsCSd1scSch0dBMFFmwCFXTeYSK8/A4DvNkByMP7y1XnPX9bk5nQU nUPkQYPC81lPCmipIqzji6PRccyzfBUqcznXPtSSc7ZirDVogd27ZR7uwf/icoHi0NfK j/8A== X-Gm-Message-State: AOAM531by5o4VpDmPw7VYoJFuC9fITVXyVZ6uBRxtRa0+HDep6UtnoVQ brnPpk4Dsko3qp8vxt5cAuqTGh50pX07Ggj6tOKoJjVHUezk7jQ6lV1mepraT8sPjMllj42hRLs 6COC+bH1q17FH2Yg/42OUrbBUtHX+OOh4zv43RUaygw== X-Received: by 2002:a17:906:30d8:: with SMTP id b24mr21486598ejb.358.1629463733473; Fri, 20 Aug 2021 05:48:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzEA4LvHamf6qG6ri+17OoBEIe8kZxRulHqECry6rlL5gh8PL/y/8DEYXFpdW+LnXDSZLDtA== X-Received: by 2002:a17:906:30d8:: with SMTP id b24mr21486588ejb.358.1629463733338; Fri, 20 Aug 2021 05:48:53 -0700 (PDT) Received: from [192.168.8.102] ([86.32.42.198]) by smtp.gmail.com with ESMTPSA id q21sm2800011eji.59.2021.08.20.05.48.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Aug 2021 05:48:53 -0700 (PDT) Subject: Re: [PATCH 1/2] arm64: dts: allwinner: h5: align operating-points table name with dtschema To: wens@csie.org Cc: Rob Herring , Maxime Ripard , Jernej Skrabec , devicetree , linux-arm-kernel , linux-sunxi@lists.linux.dev, linux-kernel References: <20210820081645.83796-1-krzysztof.kozlowski@canonical.com> From: Krzysztof Kozlowski Message-ID: Date: Fri, 20 Aug 2021 14:48:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/08/2021 14:11, Chen-Yu Tsai wrote: > On Fri, Aug 20, 2021 at 4:16 PM Krzysztof Kozlowski > wrote: >> >> Align the name of operating-points node to dtschema to fix warnings like: >> >> arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dt.yaml: >> cpu-opp-table: $nodename:0: 'cpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$' >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi >> index b2657201957e..0b6914a165b0 100644 >> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi >> @@ -2,7 +2,7 @@ >> // Copyright (C) 2020 Chen-Yu Tsai >> >> / { >> - cpu_opp_table: cpu-opp-table { >> + cpu_opp_table: opp-table-0 { > > Maybe we should just reorder the name? Name it "opp-table-cpu" instead. > That way if and when we add one for the GPU, we don't accidentally > clash on the name. Although the schema allows such name, but still the devicetree specification says that name should be generic (representing generic type of a device). Just like there is a "clock-controller" or "nand-controller", there should be generic "opp-table". Best regards, Krzysztof