From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 277A4C43381 for ; Sun, 17 Feb 2019 09:38:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DD8BF2192D for ; Sun, 17 Feb 2019 09:38:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lechnology.com header.i=@lechnology.com header.b="nJHNQ4BL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727045AbfBQJiM (ORCPT ); Sun, 17 Feb 2019 04:38:12 -0500 Received: from vern.gendns.com ([98.142.107.122]:52488 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725769AbfBQJiM (ORCPT ); Sun, 17 Feb 2019 04:38:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lechnology.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Tg7atT9isVHgD7z+wP3NGPc0yCfGa2DJ3Y8XHHBIgp8=; b=nJHNQ4BLAbiUA8p2edaGKfPlwY RQfWbv56BDbDV32rC1RNU8hQ+cCrFkUE7fD3WC+ZunaA86c7C2S50f1lRx/EUMZSX82GxFEUWVQgl 2yUvADZRHgycjgGBek/Mk5F1KDfj7DqAad67IvmQ/Z132P7i8+mmVgMI/iO1xGo8ib3FRCsMXNuIV BvIDegQIhfaUfqQpmZbZEm6HL2hvyK9X+yNAl8CkoW9pu1ewDrlUSnh+PbW1LdTSlxwKU9OEeLW6+ 0W0EI+Z7ON1yJT5EZWzX76ghz3gwh5UVnFUJlvLomfTlevOIR75ojTbsY+IozQTVeIznNiYwlGAsV ezSCmOSw==; Received: from [185.122.190.68] (port=40637 helo=gerda-5.local) by vern.gendns.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1gvItb-0005ih-BQ; Sun, 17 Feb 2019 04:37:59 -0500 Subject: Re: [PATCH v4 09/37] ARM: davinci: make irqs.h a local header To: Bartosz Golaszewski , Dmitry Torokhov , Sekhar Nori , Kevin Hilman , Thomas Gleixner , Jason Cooper , Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski References: <20190214145231.8750-1-brgl@bgdev.pl> <20190214145231.8750-10-brgl@bgdev.pl> From: David Lechner Message-ID: Date: Sun, 17 Feb 2019 10:38:06 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190214145231.8750-10-brgl@bgdev.pl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/14/19 8:52 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The existence of irqs.h in mach-davinci/include/mach only makes sense > without SPARSE_IRQ as it's then expected to define NR_IRQS and is > included from asm/irq.h. As we now support SPARSE_IRQ, this header can > be moved to mach-davinci and used as the source of HW interrupt numbers. > > While updating the includes in various files - also rearrange the > headers by directory (linux/asm/mach). > > Signed-off-by: Bartosz Golaszewski > --- Reviewed-by: David Lechner > diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-davinci/board-dm646x-evm.c > index 8d5be6dd2019..26c123f35350 100644 > --- a/arch/arm/mach-davinci/board-dm646x-evm.c > +++ b/arch/arm/mach-davinci/board-dm646x-evm.c > @@ -44,10 +44,11 @@ > #include > > #include > -#include > + We could leave out the blank line here. > #include > > #include "davinci.h" > +#include "irqs.h" > > #define NAND_BLOCK_SIZE SZ_128K > ... > diff --git a/arch/arm/mach-davinci/usb.c b/arch/arm/mach-davinci/usb.c > index 9d4a58a3113a..1e14e964c34d 100644 > --- a/arch/arm/mach-davinci/usb.c > +++ b/arch/arm/mach-davinci/usb.c > @@ -5,13 +5,13 @@ > #include > #include > #include Could put dma-mapping.h before init.h here too. > - > +#include > #include > > #include > -#include > #include > -#include > + > +#include "irqs.h" > > #define DAVINCI_USB_OTG_BASE 0x01c64000 > >