From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAA9BC4332F for ; Tue, 10 May 2022 01:19:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234133AbiEJBXY (ORCPT ); Mon, 9 May 2022 21:23:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229696AbiEJBXW (ORCPT ); Mon, 9 May 2022 21:23:22 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEF3020F74F; Mon, 9 May 2022 18:19:26 -0700 (PDT) Received: from dggpemm500022.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Ky0Xk5hTkz1JBxm; Tue, 10 May 2022 09:18:14 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500022.china.huawei.com (7.185.36.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 10 May 2022 09:19:25 +0800 Received: from [10.174.178.174] (10.174.178.174) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 10 May 2022 09:19:24 +0800 Subject: Re: [PATCH] media: camss: csid: fix wrong size passed to devm_kmalloc_array() From: Yang Yingliang To: , , CC: , , , , References: <20220509140439.1361352-1-yangyingliang@huawei.com> Message-ID: Date: Tue, 10 May 2022 09:19:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20220509140439.1361352-1-yangyingliang@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.174.178.174] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I made a mistake, this patch was sent twice, please ignore this patch. Thanks, Yang On 2022/5/9 22:04, Yang Yingliang wrote: > 'supplies' is a pointer, the real size of struct regulator_bulk_data > should be pass to devm_kmalloc_array(). > > Fixes: 0d8140179715 ("media: camss: Add regulator_bulk support") > Signed-off-by: Yang Yingliang > --- > drivers/media/platform/qcom/camss/camss-csid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c > index f993f349b66b..80628801cf09 100644 > --- a/drivers/media/platform/qcom/camss/camss-csid.c > +++ b/drivers/media/platform/qcom/camss/camss-csid.c > @@ -666,7 +666,7 @@ int msm_csid_subdev_init(struct camss *camss, struct csid_device *csid, > if (csid->num_supplies) { > csid->supplies = devm_kmalloc_array(camss->dev, > csid->num_supplies, > - sizeof(csid->supplies), > + sizeof(*csid->supplies), > GFP_KERNEL); > if (!csid->supplies) > return -ENOMEM;