From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F2E7C388F9 for ; Thu, 19 Nov 2020 07:02:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D07C2224E for ; Thu, 19 Nov 2020 07:02:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726096AbgKSHCd (ORCPT ); Thu, 19 Nov 2020 02:02:33 -0500 Received: from mxout70.expurgate.net ([194.37.255.70]:59813 "EHLO mxout70.expurgate.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725648AbgKSHCc (ORCPT ); Thu, 19 Nov 2020 02:02:32 -0500 Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.90) (envelope-from ) id 1kfdxZ-0000G6-Lp; Thu, 19 Nov 2020 08:02:25 +0100 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90) (envelope-from ) id 1kfdxY-00041v-LI; Thu, 19 Nov 2020 08:02:24 +0100 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id 2842F240041; Thu, 19 Nov 2020 08:02:24 +0100 (CET) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 9AFCD240040; Thu, 19 Nov 2020 08:02:23 +0100 (CET) Received: from mail.dev.tdt.de (localhost [IPv6:::1]) by mail.dev.tdt.de (Postfix) with ESMTP id 0E83620115; Thu, 19 Nov 2020 08:02:23 +0100 (CET) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 19 Nov 2020 08:02:22 +0100 From: Martin Schiller To: Xie He Cc: Andrew Hendry , "David S. Miller" , Jakub Kicinski , Linux X25 , Linux Kernel Network Developers , LKML Subject: Re: [PATCH net-next v3 0/6] net/x25: netdev event handling Organization: TDT AG In-Reply-To: References: <20201118135919.1447-1-ms@dev.tdt.de> Message-ID: X-Sender: ms@dev.tdt.de User-Agent: Roundcube Webmail/1.3.15 X-purgate-ID: 151534::1605769345-000013A4-5B5B5D59/0/0 X-purgate-type: clean X-purgate: clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-11-18 15:47, Xie He wrote: > On Wed, Nov 18, 2020 at 5:59 AM Martin Schiller wrote: >> >> --- >> Changes to v2: >> o restructure complete patch-set >> o keep netdev event handling in layer3 (X.25) > > But... Won't it be better to handle L2 connections in L2 code? > > For example, if we are running X.25 over XOT, we can decide in the XOT > layer whether and when we reconnect in case the TCP connection is > dropped. We can decide how long we wait for responses before we > consider the TCP connection to be dropped. > > If we still want "on-demand" connections in certain L2's, we can also > implement it in that L2 without the need to change L3. > > Every L2 has its own characteristics. It might be better to let > different L2's handle their connections in their own way. This gives > L2 the flexibility to handle their connections according to their > actual link characteristics. > > Letting L3 handle L2 connections also makes L2 code too related to / > coupled with L3 code, which makes the logic complex. OK, I will give it a try. But we need to keep the possibility to initiate and terminate the L2 connection from L3. In the on demand scenario i mentioned, the L2 should be connected when the first L3 logical channel goes up and needs to be disconnected, when the last L3 logical channel on an interface is cleared. > >> o add patch to fix lapb_connect_request() for DCE >> o add patch to handle carrier loss correctly in lapb >> o drop patch for x25_neighbour param handling >> this may need fixes/cleanup and will be resubmitted later. >> >> Changes to v1: >> o fix 'subject_prefix' and 'checkpatch' warnings >> >> --- >> >> Martin Schiller (6): >> net/x25: handle additional netdev events >> net/lapb: fix lapb_connect_request() for DCE >> net/lapb: handle carrier loss correctly >> net/lapb: fix t1 timer handling for DCE >> net/x25: fix restart request/confirm handling >> net/x25: remove x25_kill_by_device()