From: Jens Axboe <axboe@kernel.dk>
To: Hillf Danton <hdanton@sina.com>, io-uring@vger.kernel.org
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm <linux-mm@kvack.org>
Subject: Re: [RFC PATCH] io-wq: kill cpu hog worker
Date: Mon, 23 Dec 2019 08:15:00 -0700 [thread overview]
Message-ID: <ae2945f0-c3ff-7d78-4947-f87c3026100e@kernel.dk> (raw)
In-Reply-To: <20191223024145.11580-1-hdanton@sina.com>
On 12/22/19 7:41 PM, Hillf Danton wrote:
>
> Reschedule the current IO worker if it is becoming a cpu hog.
Might make more sense to put this a bit earlier, to avoid the
awkward lock juggle. In theory it shouldn't make a difference
if we do it _before_ doing new work, or _after_ doing work. We
should only be rescheduling if it's running for quite a while.
How about putting it after the flushing of signals instead?
--
Jens Axboe
next parent reply other threads:[~2019-12-23 15:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191223024145.11580-1-hdanton@sina.com>
2019-12-23 15:15 ` Jens Axboe [this message]
[not found] ` <20191224115415.1360-1-hdanton@sina.com>
2019-12-24 16:13 ` [RFC PATCH] io-wq: kill cpu hog worker Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae2945f0-c3ff-7d78-4947-f87c3026100e@kernel.dk \
--to=axboe@kernel.dk \
--cc=hdanton@sina.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).