* [PATCH] iommu: APPLE_DART should depend on ARCH_APPLE
@ 2021-08-10 13:47 Geert Uytterhoeven
2021-08-11 10:58 ` Sven Peter
2021-08-12 11:27 ` Joerg Roedel
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-08-10 13:47 UTC (permalink / raw)
To: Sven Peter, Joerg Roedel, Will Deacon, Hector Martin
Cc: iommu, linux-arm-kernel, linux-kernel, Geert Uytterhoeven
The Apple DART (Device Address Resolution Table) IOMMU is only present
on Apple ARM SoCs like the M1. Hence add a dependency on ARCH_APPLE, to
prevent asking the user about this driver when configuring a kernel
without support for the Apple Silicon SoC family.
Fixes: 05ce9d20d699b093 ("iommu/dart: Add DART iommu driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/iommu/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
index dfe81da483e9e073..e908b8222e4ed679 100644
--- a/drivers/iommu/Kconfig
+++ b/drivers/iommu/Kconfig
@@ -292,7 +292,7 @@ config SPAPR_TCE_IOMMU
config APPLE_DART
tristate "Apple DART IOMMU Support"
- depends on ARM64 || (COMPILE_TEST && !GENERIC_ATOMIC64)
+ depends on ARCH_APPLE || (COMPILE_TEST && !GENERIC_ATOMIC64)
select IOMMU_API
select IOMMU_IO_PGTABLE_LPAE
default ARCH_APPLE
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu: APPLE_DART should depend on ARCH_APPLE
2021-08-10 13:47 [PATCH] iommu: APPLE_DART should depend on ARCH_APPLE Geert Uytterhoeven
@ 2021-08-11 10:58 ` Sven Peter
2021-08-12 11:27 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Sven Peter @ 2021-08-11 10:58 UTC (permalink / raw)
To: Geert Uytterhoeven, Joerg Roedel, Will Deacon, Hector Martin
Cc: iommu, linux-arm-kernel, linux-kernel
Good catch, thanks!
Acked-by: Sven Peter <sven@svenpeter.dev>
Sven
On Tue, Aug 10, 2021, at 15:47, Geert Uytterhoeven wrote:
> The Apple DART (Device Address Resolution Table) IOMMU is only present
> on Apple ARM SoCs like the M1. Hence add a dependency on ARCH_APPLE, to
> prevent asking the user about this driver when configuring a kernel
> without support for the Apple Silicon SoC family.
>
> Fixes: 05ce9d20d699b093 ("iommu/dart: Add DART iommu driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/iommu/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index dfe81da483e9e073..e908b8222e4ed679 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -292,7 +292,7 @@ config SPAPR_TCE_IOMMU
>
> config APPLE_DART
> tristate "Apple DART IOMMU Support"
> - depends on ARM64 || (COMPILE_TEST && !GENERIC_ATOMIC64)
> + depends on ARCH_APPLE || (COMPILE_TEST && !GENERIC_ATOMIC64)
> select IOMMU_API
> select IOMMU_IO_PGTABLE_LPAE
> default ARCH_APPLE
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu: APPLE_DART should depend on ARCH_APPLE
2021-08-10 13:47 [PATCH] iommu: APPLE_DART should depend on ARCH_APPLE Geert Uytterhoeven
2021-08-11 10:58 ` Sven Peter
@ 2021-08-12 11:27 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Joerg Roedel @ 2021-08-12 11:27 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Sven Peter, Will Deacon, Hector Martin, iommu, linux-arm-kernel,
linux-kernel
On Tue, Aug 10, 2021 at 03:47:19PM +0200, Geert Uytterhoeven wrote:
> The Apple DART (Device Address Resolution Table) IOMMU is only present
> on Apple ARM SoCs like the M1. Hence add a dependency on ARCH_APPLE, to
> prevent asking the user about this driver when configuring a kernel
> without support for the Apple Silicon SoC family.
>
> Fixes: 05ce9d20d699b093 ("iommu/dart: Add DART iommu driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/iommu/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index dfe81da483e9e073..e908b8222e4ed679 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -292,7 +292,7 @@ config SPAPR_TCE_IOMMU
>
> config APPLE_DART
> tristate "Apple DART IOMMU Support"
> - depends on ARM64 || (COMPILE_TEST && !GENERIC_ATOMIC64)
> + depends on ARCH_APPLE || (COMPILE_TEST && !GENERIC_ATOMIC64)
> select IOMMU_API
> select IOMMU_IO_PGTABLE_LPAE
> default ARCH_APPLE
Dropped the Fixes tag, as this doesn't fix any real issue. Otherwise
applied with adjusted subject (iommu: -> iommu/dart:), Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-12 11:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-10 13:47 [PATCH] iommu: APPLE_DART should depend on ARCH_APPLE Geert Uytterhoeven
2021-08-11 10:58 ` Sven Peter
2021-08-12 11:27 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).