From: John Garry <john.g.garry@oracle.com>
To: Jing Zhang <renyu.zj@linux.alibaba.com>
Cc: James Clark <james.clark@arm.com>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Ilkka Koskinen <ilkka@os.amperecomputing.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org,
Zhuo Song <zhuo.song@linux.alibaba.com>,
Ian Rogers <irogers@google.com>, Will Deacon <will@kernel.org>,
Shuai Xue <xueshuai@linux.alibaba.com>,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v3 2/7] perf metric: Event "Compat" value supports matching multiple identifiers
Date: Tue, 20 Jun 2023 08:01:20 +0100 [thread overview]
Message-ID: <ae596b0c-e0bc-2b08-c348-0927acc0c8ef@oracle.com> (raw)
In-Reply-To: <777e06ae-fd9c-8fd3-6976-7b80594e1942@linux.alibaba.com>
On 20/06/2023 03:12, Jing Zhang wrote:
>> But that JSON is not in this series. Why is it not included?
>>
> Because the RFC version of the cmn.json file does not define the EventCode for each event, this will not take effect, so I temporarily removed it.
> The EventID of CMN events is different from other events. For example, hnf_slc_sf_cache_access corresponds to arm_cmn_0/type=0x5,eventid=0x2/.
> The current JSON format parsing does not support this EventID, and jevent.py needs to be extended.
So please do that then. I would suggest just to first support event
aliasing, and then support metrics. JFYI, I am still reworking current
perf tool metric code for sys events, which should take a few more days.
>
>> The cmn kernel driver exposes event hnf_slc_sf_cache_access, but I did not think that perf tool metric code matches those events described in/bus/event_sourcs/devices/<PMU>/events
>>
> If there is no alias defined, other events with the same name may be matched, it is indeed necessary to define an alias for each event first,
> and I will add it in the next version. But first I need to extend jevent.py to support cmn EventID.
ok, please do this. I assume that you are talking about wildcard
matching for cmn HW identifier. We would also need perf tool self-test
expanded to cover this wildcard matching - see tests/pmu-events.c
Thanks,
John
next prev parent reply other threads:[~2023-06-20 7:02 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 9:19 [PATCH v3 0/7] Add JSON metrics for arm CMN and Yitian710 DDR Jing Zhang
2023-05-30 9:19 ` [PATCH v3 1/7] driver/perf: Add identifier sysfs file for CMN Jing Zhang
2023-05-31 2:58 ` kernel test robot
2023-05-30 9:19 ` [PATCH v3 2/7] perf metric: Event "Compat" value supports matching multiple identifiers Jing Zhang
2023-05-31 13:18 ` John Garry
2023-06-01 8:58 ` Jing Zhang
2023-06-02 16:20 ` John Garry
2023-06-05 2:46 ` Jing Zhang
2023-06-05 19:39 ` Arnaldo Carvalho de Melo
2023-06-15 3:41 ` Jing Zhang
2023-06-23 23:52 ` Namhyung Kim
2023-06-25 8:55 ` Jing Zhang
2023-06-06 14:11 ` John Garry
2023-06-08 9:44 ` Jing Zhang
2023-06-12 18:15 ` John Garry
2023-06-13 16:36 ` John Garry
2023-06-15 2:18 ` Jing Zhang
2023-06-16 11:41 ` John Garry
2023-06-19 2:58 ` Jing Zhang
2023-06-19 7:07 ` John Garry
2023-06-19 8:59 ` Jing Zhang
2023-06-19 9:31 ` John Garry
2023-06-20 2:12 ` Jing Zhang
2023-06-20 7:01 ` John Garry [this message]
2023-06-21 3:15 ` Jing Zhang
2023-06-06 16:27 ` Robin Murphy
2023-06-08 10:11 ` Jing Zhang
2023-05-30 9:19 ` [PATCH v3 3/7] perf vendor events: Add JSON metrics for CMN Jing Zhang
2023-05-31 1:18 ` Ian Rogers
2023-06-01 9:03 ` Jing Zhang
2023-05-31 2:43 ` Shuai Xue
2023-06-01 9:06 ` Jing Zhang
2023-05-30 9:19 ` [PATCH v3 4/7] driver/perf: Add identifier sysfs file for Yitian 710 DDR Jing Zhang
2023-05-30 9:19 ` [PATCH v3 5/7] perf jevents: Add support for Yitian 710 DDR PMU aliasing Jing Zhang
2023-05-30 9:19 ` [PATCH v3 6/7] perf vendor events: Add JSON metrics for Yitian 710 DDR Jing Zhang
2023-05-30 9:19 ` [PATCH v3 7/7] docs: perf: Update metric usage for Alibaba's T-Head PMU driver Jing Zhang
2023-05-31 1:19 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae596b0c-e0bc-2b08-c348-0927acc0c8ef@oracle.com \
--to=john.g.garry@oracle.com \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ilkka@os.amperecomputing.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=namhyung@kernel.org \
--cc=renyu.zj@linux.alibaba.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=xueshuai@linux.alibaba.com \
--cc=zhuo.song@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).