* [PATCH] sched/fair: Set se->vruntime directly in place_entity()
@ 2012-11-08 8:03 Viresh Kumar
2013-01-02 5:44 ` Viresh Kumar
2013-01-24 20:44 ` [tip:sched/core] sched/fair: Set se-> vruntime " tip-bot for Viresh Kumar
0 siblings, 2 replies; 3+ messages in thread
From: Viresh Kumar @ 2012-11-08 8:03 UTC (permalink / raw)
To: mingo, peterz; +Cc: linaro-dev, patches, linux-kernel, Viresh Kumar
We are first storing the new vruntime in a variable and then storing it in
se->vruntime. Simply update se->vruntime directly.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
kernel/sched/fair.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index a319d56c..820a2f1 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1454,9 +1454,7 @@ place_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int initial)
}
/* ensure we never gain time by being placed backwards. */
- vruntime = max_vruntime(se->vruntime, vruntime);
-
- se->vruntime = vruntime;
+ se->vruntime = max_vruntime(se->vruntime, vruntime);
}
static void check_enqueue_throttle(struct cfs_rq *cfs_rq);
--
1.7.12.rc2.18.g61b472e
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sched/fair: Set se->vruntime directly in place_entity()
2012-11-08 8:03 [PATCH] sched/fair: Set se->vruntime directly in place_entity() Viresh Kumar
@ 2013-01-02 5:44 ` Viresh Kumar
2013-01-24 20:44 ` [tip:sched/core] sched/fair: Set se-> vruntime " tip-bot for Viresh Kumar
1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2013-01-02 5:44 UTC (permalink / raw)
To: mingo, peterz; +Cc: linaro-dev, patches, linux-kernel, Viresh Kumar
On 8 November 2012 13:33, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> We are first storing the new vruntime in a variable and then storing it in
> se->vruntime. Simply update se->vruntime directly.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> kernel/sched/fair.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index a319d56c..820a2f1 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -1454,9 +1454,7 @@ place_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int initial)
> }
>
> /* ensure we never gain time by being placed backwards. */
> - vruntime = max_vruntime(se->vruntime, vruntime);
> -
> - se->vruntime = vruntime;
> + se->vruntime = max_vruntime(se->vruntime, vruntime);
> }
Ping!!
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:sched/core] sched/fair: Set se-> vruntime directly in place_entity()
2012-11-08 8:03 [PATCH] sched/fair: Set se->vruntime directly in place_entity() Viresh Kumar
2013-01-02 5:44 ` Viresh Kumar
@ 2013-01-24 20:44 ` tip-bot for Viresh Kumar
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Viresh Kumar @ 2013-01-24 20:44 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, viresh.kumar, tglx
Commit-ID: 16c8f1c72ece3871a6c93003cd888fc2d003a7eb
Gitweb: http://git.kernel.org/tip/16c8f1c72ece3871a6c93003cd888fc2d003a7eb
Author: Viresh Kumar <viresh.kumar@linaro.org>
AuthorDate: Thu, 8 Nov 2012 13:33:46 +0530
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 24 Jan 2013 18:06:11 +0100
sched/fair: Set se->vruntime directly in place_entity()
We are first storing the new vruntime in a variable and then
storing it in se->vruntime. Simply update se->vruntime directly.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linaro-dev@lists.linaro.org
Cc: patches@linaro.org
Cc: peterz@infradead.org
Link: http://lkml.kernel.org/r/ae59db1945518d6f6250920d46eb1f1a9cc0024e.1352361704.git.viresh.kumar@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/sched/fair.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index a7a19ff..8dbee9f 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1680,9 +1680,7 @@ place_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int initial)
}
/* ensure we never gain time by being placed backwards. */
- vruntime = max_vruntime(se->vruntime, vruntime);
-
- se->vruntime = vruntime;
+ se->vruntime = max_vruntime(se->vruntime, vruntime);
}
static void check_enqueue_throttle(struct cfs_rq *cfs_rq);
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-24 20:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-08 8:03 [PATCH] sched/fair: Set se->vruntime directly in place_entity() Viresh Kumar
2013-01-02 5:44 ` Viresh Kumar
2013-01-24 20:44 ` [tip:sched/core] sched/fair: Set se-> vruntime " tip-bot for Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).