* [PATCH] arm64: dts: imx: Fix imx8mm-kontron-n801x-s.dtb target
@ 2020-11-08 2:23 Nathan Chancellor
2020-11-08 9:31 ` Krzysztof Kozlowski
2020-11-08 19:16 ` [PATCH v2] " Nathan Chancellor
0 siblings, 2 replies; 7+ messages in thread
From: Nathan Chancellor @ 2020-11-08 2:23 UTC (permalink / raw)
To: Shawn Guo
Cc: Rob Herring, Frieder Schrempf, Krzysztof Kozlowski,
linux-arm-kernel, devicetree, linux-kernel, Nathan Chancellor
$ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux- \
INSTALL_DTBS_PATH=rootfs distclean defconfig dtbs dtbs_install
...
make[3]: *** No rule to make target
'rootfs/freescale/imx8mm-kontron-n801x-s.dts', needed by
'__dtbs_install'
...
It should be .dtb, not .dts.
Fixes: 8668d8b2e67f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
arch/arm64/boot/dts/freescale/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index 876bf484bbe6..6f0777ee6cd6 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -32,7 +32,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
-dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dts
+dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr4-evk.dtb
base-commit: 39fabe22e0f8c00334882ceac1dc70ffbd7f4871
--
2.29.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: imx: Fix imx8mm-kontron-n801x-s.dtb target
2020-11-08 2:23 [PATCH] arm64: dts: imx: Fix imx8mm-kontron-n801x-s.dtb target Nathan Chancellor
@ 2020-11-08 9:31 ` Krzysztof Kozlowski
2020-11-08 19:13 ` Nathan Chancellor
2020-11-08 19:16 ` [PATCH v2] " Nathan Chancellor
1 sibling, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-08 9:31 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Shawn Guo, Rob Herring, Frieder Schrempf, linux-arm-kernel,
devicetree, linux-kernel
On Sun, 8 Nov 2020 at 03:23, Nathan Chancellor <natechancellor@gmail.com> wrote:
Hi,
Thanks for the fixes.
Please mark patches with versions, this should be v2. Otherwise
maintainer might apply the older one,
You also need to add versioning changelog after ---.
> $ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux- \
> INSTALL_DTBS_PATH=rootfs distclean defconfig dtbs dtbs_install
All this is still irrelevant. Just: "make dtbs". Don't add unrelated
details like how many processes you spawn, where do you want to
install DTBS or even all other make targets.
Everyone should know how to cross compile so simple: make dtbs
> ...
> make[3]: *** No rule to make target
> 'rootfs/freescale/imx8mm-kontron-n801x-s.dts', needed by
> '__dtbs_install'
This should be joined with previous line. I mentioned it in your previous patch.
> ...
Also not needed dots. This is small change and should go with small
and accurate description. Blowing the description does not help.
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: imx: Fix imx8mm-kontron-n801x-s.dtb target
2020-11-08 9:31 ` Krzysztof Kozlowski
@ 2020-11-08 19:13 ` Nathan Chancellor
2020-11-08 19:16 ` Krzysztof Kozlowski
0 siblings, 1 reply; 7+ messages in thread
From: Nathan Chancellor @ 2020-11-08 19:13 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Shawn Guo, Rob Herring, Frieder Schrempf, linux-arm-kernel,
devicetree, linux-kernel
Hi Krzysztof,
On Sun, Nov 08, 2020 at 10:31:10AM +0100, Krzysztof Kozlowski wrote:
> On Sun, 8 Nov 2020 at 03:23, Nathan Chancellor <natechancellor@gmail.com> wrote:
>
> Hi,
>
> Thanks for the fixes.
>
> Please mark patches with versions, this should be v2. Otherwise
> maintainer might apply the older one,
> You also need to add versioning changelog after ---.
I have only sent this one patch. It looks like Anders Roxell sent an
identical patch though:
https://lore.kernel.org/linux-devicetree/20201105111823.1613337-1-anders.roxell@linaro.org/
> > $ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux- \
> > INSTALL_DTBS_PATH=rootfs distclean defconfig dtbs dtbs_install
>
> All this is still irrelevant. Just: "make dtbs". Don't add unrelated
> details like how many processes you spawn, where do you want to
> install DTBS or even all other make targets.
> Everyone should know how to cross compile so simple: make dtbs
Sure, I will update it, my apologies.
> > ...
> > make[3]: *** No rule to make target
> > 'rootfs/freescale/imx8mm-kontron-n801x-s.dts', needed by
> > '__dtbs_install'
>
> This should be joined with previous line. I mentioned it in your previous patch.
Sure, I usually just let my editor do the auto wrapping but I will put
it all onto one line!
> > ...
>
> Also not needed dots. This is small change and should go with small
> and accurate description. Blowing the description does not help.
>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Best regards,
> Krzysztof
Thank you for the review, I will sent v2 along shortly.
Cheers,
Nathan
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] arm64: dts: imx: Fix imx8mm-kontron-n801x-s.dtb target
2020-11-08 2:23 [PATCH] arm64: dts: imx: Fix imx8mm-kontron-n801x-s.dtb target Nathan Chancellor
2020-11-08 9:31 ` Krzysztof Kozlowski
@ 2020-11-08 19:16 ` Nathan Chancellor
2020-11-09 8:05 ` Frieder Schrempf
2020-11-10 3:03 ` Shawn Guo
1 sibling, 2 replies; 7+ messages in thread
From: Nathan Chancellor @ 2020-11-08 19:16 UTC (permalink / raw)
To: Shawn Guo
Cc: Rob Herring, Frieder Schrempf, Krzysztof Kozlowski,
linux-arm-kernel, devicetree, linux-kernel, Nathan Chancellor
While running 'make dtbs_install', the following error occurs:
make[3]: *** No rule to make target 'rootfs/freescale/imx8mm-kontron-n801x-s.dts', needed by '__dtbs_install'.
It should be .dtb, not .dts.
Fixes: 8668d8b2e67f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards")
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
v1 -> v2:
* Simplify commit message and error (Krzysztof).
* Pick up Krzysztof's tag.
arch/arm64/boot/dts/freescale/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index 876bf484bbe6..6f0777ee6cd6 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -32,7 +32,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
-dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dts
+dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr4-evk.dtb
base-commit: 39fabe22e0f8c00334882ceac1dc70ffbd7f4871
--
2.29.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: imx: Fix imx8mm-kontron-n801x-s.dtb target
2020-11-08 19:13 ` Nathan Chancellor
@ 2020-11-08 19:16 ` Krzysztof Kozlowski
0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-08 19:16 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Shawn Guo, Rob Herring, Frieder Schrempf, linux-arm-kernel,
devicetree, linux-kernel
On Sun, 8 Nov 2020 at 20:13, Nathan Chancellor <natechancellor@gmail.com> wrote:
>
> Hi Krzysztof,
>
> On Sun, Nov 08, 2020 at 10:31:10AM +0100, Krzysztof Kozlowski wrote:
> > On Sun, 8 Nov 2020 at 03:23, Nathan Chancellor <natechancellor@gmail.com> wrote:
> >
> > Hi,
> >
> > Thanks for the fixes.
> >
> > Please mark patches with versions, this should be v2. Otherwise
> > maintainer might apply the older one,
> > You also need to add versioning changelog after ---.
>
> I have only sent this one patch. It looks like Anders Roxell sent an
> identical patch though:
>
> https://lore.kernel.org/linux-devicetree/20201105111823.1613337-1-anders.roxell@linaro.org/
Oh, damn, I didn't check the authors and got kind of confused seeing a
v1. Nice timing. :)
Anyway, thanks for the patch!
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] arm64: dts: imx: Fix imx8mm-kontron-n801x-s.dtb target
2020-11-08 19:16 ` [PATCH v2] " Nathan Chancellor
@ 2020-11-09 8:05 ` Frieder Schrempf
2020-11-10 3:03 ` Shawn Guo
1 sibling, 0 replies; 7+ messages in thread
From: Frieder Schrempf @ 2020-11-09 8:05 UTC (permalink / raw)
To: Nathan Chancellor, Shawn Guo
Cc: Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, devicetree,
linux-kernel
On 08.11.20 20:16, Nathan Chancellor wrote:
> While running 'make dtbs_install', the following error occurs:
>
> make[3]: *** No rule to make target 'rootfs/freescale/imx8mm-kontron-n801x-s.dts', needed by '__dtbs_install'.
>
> It should be .dtb, not .dts.
>
> Fixes: 8668d8b2e67f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards")
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Thanks for fixing my error!
I often use Yocto to build the kernel and it doesn't use "make dtbs",
but reference single dtbs directly by its name. I probably should have
tested this more properly.
Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> ---
>
> v1 -> v2:
>
> * Simplify commit message and error (Krzysztof).
> * Pick up Krzysztof's tag.
>
> arch/arm64/boot/dts/freescale/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 876bf484bbe6..6f0777ee6cd6 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -32,7 +32,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
> -dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dts
> +dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr4-evk.dtb
>
> base-commit: 39fabe22e0f8c00334882ceac1dc70ffbd7f4871
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] arm64: dts: imx: Fix imx8mm-kontron-n801x-s.dtb target
2020-11-08 19:16 ` [PATCH v2] " Nathan Chancellor
2020-11-09 8:05 ` Frieder Schrempf
@ 2020-11-10 3:03 ` Shawn Guo
1 sibling, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2020-11-10 3:03 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Rob Herring, Frieder Schrempf, Krzysztof Kozlowski,
linux-arm-kernel, devicetree, linux-kernel
On Sun, Nov 08, 2020 at 12:16:15PM -0700, Nathan Chancellor wrote:
> While running 'make dtbs_install', the following error occurs:
>
> make[3]: *** No rule to make target 'rootfs/freescale/imx8mm-kontron-n801x-s.dts', needed by '__dtbs_install'.
>
> It should be .dtb, not .dts.
>
> Fixes: 8668d8b2e67f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards")
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-11-10 3:03 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-08 2:23 [PATCH] arm64: dts: imx: Fix imx8mm-kontron-n801x-s.dtb target Nathan Chancellor
2020-11-08 9:31 ` Krzysztof Kozlowski
2020-11-08 19:13 ` Nathan Chancellor
2020-11-08 19:16 ` Krzysztof Kozlowski
2020-11-08 19:16 ` [PATCH v2] " Nathan Chancellor
2020-11-09 8:05 ` Frieder Schrempf
2020-11-10 3:03 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).