From: Tom Rix <trix@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atm: ambassador: remove h from printk format specifier
Date: Thu, 17 Dec 2020 14:03:07 -0800 [thread overview]
Message-ID: <ae7d363b-99ec-d75f-bae3-add3ee4789bd@redhat.com> (raw)
In-Reply-To: <20201217092816.7b739b8c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 12/17/20 9:28 AM, Jakub Kicinski wrote:
> On Thu, 17 Dec 2020 05:17:24 -0800 Tom Rix wrote:
>> On 12/16/20 4:45 PM, Jakub Kicinski wrote:
>>> On Tue, 15 Dec 2020 06:22:28 -0800 trix@redhat.com wrote:
>>>> From: Tom Rix <trix@redhat.com>
>>>>
>>>> See Documentation/core-api/printk-formats.rst.
>>>> h should no longer be used in the format specifier for printk.
>>>>
>>>> Signed-off-by: Tom Rix <trix@redhat.com>
>>> That's for new code I assume?
>>>
>>> What's the harm in leaving this ancient code be?
>> This change is part of a tree wide cleanup.
> What's the purpose of the "clean up"? Why is it making the code better?
>
> This is a quote from your change:
>
> - PRINTK (KERN_NOTICE, "debug bitmap is %hx", debug &= DBG_MASK);
> + PRINTK (KERN_NOTICE, "debug bitmap is %x", debug &= DBG_MASK);
>
> Are you sure that the use of %hx is the worst part of that line?
In this case, it means this bit of code is compliant with the %h checker in checkpatch.
why you are seeing this change for %hx and not the horrible debug &= or the old PRINTK macro is because the change was mechanical.
leveraging the clang build and a special fixit for %h, an allyesconfig for x86_64 cleans this problem from most of the tree in about an hour. atm/ was just one of the places it hit, there are about 100 more.
If you want the debug &= fixed, i can do that.
The macro is a treewide problem and i can add that to the treewide cleanups i am planning.
Tom
>
>> drivers/atm status is listed as Maintained in MAINTAINERS so changes
>> like this should be ok.
>>
>> Should drivers/atm status be changed?
> Up to Chas, but AFAIU we're probably only a few years away from ATM as
> a whole walking into the light. So IMHO "Obsolete" would be justified.
>
next prev parent reply other threads:[~2020-12-17 22:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 14:22 [PATCH] atm: ambassador: remove h from printk format specifier trix
2020-12-17 0:45 ` Jakub Kicinski
2020-12-17 13:17 ` Tom Rix
2020-12-17 17:28 ` Jakub Kicinski
2020-12-17 22:03 ` Tom Rix [this message]
2020-12-18 18:02 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae7d363b-99ec-d75f-bae3-add3ee4789bd@redhat.com \
--to=trix@redhat.com \
--cc=3chas3@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).