From: Philippe Schenker <philippe.schenker@toradex.com>
To: "jic23@kernel.org" <jic23@kernel.org>
Cc: "linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"stefan@agner.ch" <stefan@agner.ch>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
"David.Laight@ACULAB.COM" <David.Laight@ACULAB.COM>,
Max Krummenacher <max.krummenacher@toradex.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"knaack.h@gmx.de" <knaack.h@gmx.de>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
"lars@metafoo.de" <lars@metafoo.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alexandre.torgue@st.com" <alexandre.torgue@st.com>
Subject: Re: [PATCH 2/5] iio: stmpe-adc: Reinit completion struct on begin conversion
Date: Mon, 13 May 2019 07:26:03 +0000 [thread overview]
Message-ID: <ae8a2305c5ab0d312e1334e895a5e7fdb45fbd16.camel@toradex.com> (raw)
In-Reply-To: <20190511110832.24f58e4a@archlinux>
On Sat, 2019-05-11 at 11:08 +0100, Jonathan Cameron wrote:
> On Tue, 7 May 2019 16:36:12 +0200
> Philippe Schenker <dev@pschenker.ch> wrote:
>
> > From: Philippe Schenker <philippe.schenker@toradex.com>
> >
> > In some cases, the wait_completion got interrupted. This caused the
> > error-handling to mutex_unlock the function. The before turned on
> > interrupt then got called anyway. In the ISR then completion() was
> > called causing wrong adc-values returned in a following adc-readout.
> >
> > Reinitialise completion struct to make sure the counter is zero
> > when beginning a new adc-conversion.
> >
> > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> Hi Philippe,
>
> To me this looks like a fix that we should consider applying to stable.
> However, as it is in the middle of this series I'm not going to take
> it via the fast route (during rc's). If people want to backport it
> they will have to wait until after the next merge window.
> If anyone has an urgent need, then shout in the next week and I'll
> pull this version out and we can restructure the set.
>
> Applied to the togreg branch of iio.git and pushed out as testing
> for the autobuilders to play with it.
>
> Thanks,
>
> Jonathan
Hi Jonathan! I don't think that's necessary. As long as it gets into stable at
some point. Our customer use downstream anyway. Where I'm about to apply it now.
Thanks,
Philippe
>
> > ---
> >
> > drivers/iio/adc/stmpe-adc.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/iio/adc/stmpe-adc.c b/drivers/iio/adc/stmpe-adc.c
> > index 9ec338ba3440..b3872eb37293 100644
> > --- a/drivers/iio/adc/stmpe-adc.c
> > +++ b/drivers/iio/adc/stmpe-adc.c
> > @@ -65,6 +65,8 @@ static int stmpe_read_voltage(struct stmpe_adc *info,
> >
> > mutex_lock(&info->lock);
> >
> > + reinit_completion(&info->completion);
> > +
> > info->channel = (u8)chan->channel;
> >
> > if (info->channel > STMPE_ADC_LAST_NR) {
> > @@ -105,6 +107,8 @@ static int stmpe_read_temp(struct stmpe_adc *info,
> >
> > mutex_lock(&info->lock);
> >
> > + reinit_completion(&info->completion);
> > +
> > info->channel = (u8)chan->channel;
> >
> > if (info->channel != STMPE_TEMP_CHANNEL) {
next prev parent reply other threads:[~2019-05-13 7:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 14:36 [PATCH 1/5] iio: stmpe-adc: Add compatible name Philippe Schenker
2019-05-07 14:36 ` [PATCH 2/5] iio: stmpe-adc: Reinit completion struct on begin conversion Philippe Schenker
2019-05-11 10:08 ` Jonathan Cameron
2019-05-13 7:26 ` Philippe Schenker [this message]
2019-05-07 14:36 ` [PATCH 3/5] iio: stmpe-adc: Enable all stmpe-adc interrupts just once Philippe Schenker
2019-05-11 10:09 ` Jonathan Cameron
2019-05-07 14:36 ` [PATCH 4/5] iio: stmpe-adc: Use wait_for_completion_timeout Philippe Schenker
2019-05-11 10:15 ` Jonathan Cameron
2019-05-13 7:28 ` Philippe Schenker
2019-05-07 14:36 ` [PATCH 5/5] iio: stmpe-adc: Reset possible interrupts Philippe Schenker
2019-05-11 10:24 ` Jonathan Cameron
2019-05-13 7:47 ` Philippe Schenker
2019-05-08 7:01 ` [PATCH 1/5] iio: stmpe-adc: Add compatible name Lee Jones
2019-05-08 7:28 ` Philippe Schenker
2019-05-11 9:58 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae8a2305c5ab0d312e1334e895a5e7fdb45fbd16.camel@toradex.com \
--to=philippe.schenker@toradex.com \
--cc=David.Laight@ACULAB.COM \
--cc=alexandre.torgue@st.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=marcel.ziswiler@toradex.com \
--cc=max.krummenacher@toradex.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).