From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70213C2BA1A for ; Tue, 16 Mar 2021 06:58:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F11F65254 for ; Tue, 16 Mar 2021 06:58:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235856AbhCPG6F (ORCPT ); Tue, 16 Mar 2021 02:58:05 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:53503 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233679AbhCPG5l (ORCPT ); Tue, 16 Mar 2021 02:57:41 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4F03yC1wWpz9v01q; Tue, 16 Mar 2021 07:57:39 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id dAvZpDnyIIEM; Tue, 16 Mar 2021 07:57:39 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4F03yC0bC2z9v01p; Tue, 16 Mar 2021 07:57:39 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id C604A8B77F; Tue, 16 Mar 2021 07:57:39 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id 9y2Jva0TRQda; Tue, 16 Mar 2021 07:57:39 +0100 (CET) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 061878B766; Tue, 16 Mar 2021 07:57:38 +0100 (CET) Subject: Re: [PATCH] powerpc: arch/powerpc/kernel/setup_64.c - cleanup warnings To: He Ying , mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, npiggin@gmail.com, dja@axtens.net, akpm@linux-foundation.org, aneesh.kumar@linux.ibm.com, rppt@kernel.org, ardb@kernel.org, clg@kaod.org Cc: johnny.chenyi@huawei.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20210316041148.29694-1-heying24@huawei.com> From: Christophe Leroy Message-ID: Date: Tue, 16 Mar 2021 07:57:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210316041148.29694-1-heying24@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 16/03/2021 à 05:11, He Ying a écrit : > warning: symbol 'rfi_flush' was not declared. > warning: symbol 'entry_flush' was not declared. > warning: symbol 'uaccess_flush' was not declared. > We found warnings above in arch/powerpc/kernel/setup_64.c by using > sparse tool. > > Define 'entry_flush' and 'uaccess_flush' as static because they are not > referenced outside the file. Include asm/security_features.h in which > 'rfi_flush' is declared. > > Reported-by: Hulk Robot > Signed-off-by: He Ying Reviewed-by: Christophe Leroy > --- > arch/powerpc/kernel/setup_64.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c > index 560ed8b975e7..f92d72a7e7ce 100644 > --- a/arch/powerpc/kernel/setup_64.c > +++ b/arch/powerpc/kernel/setup_64.c > @@ -68,6 +68,7 @@ > #include > #include > #include > +#include > > #include "setup.h" > > @@ -949,8 +950,8 @@ static bool no_rfi_flush; > static bool no_entry_flush; > static bool no_uaccess_flush; > bool rfi_flush; > -bool entry_flush; > -bool uaccess_flush; > +static bool entry_flush; > +static bool uaccess_flush; > DEFINE_STATIC_KEY_FALSE(uaccess_flush_key); > EXPORT_SYMBOL(uaccess_flush_key); > >