From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753375AbdCBNzQ (ORCPT ); Thu, 2 Mar 2017 08:55:16 -0500 Received: from mga09.intel.com ([134.134.136.24]:23139 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752230AbdCBNyX (ORCPT ); Thu, 2 Mar 2017 08:54:23 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,231,1484035200"; d="scan'208";a="1117548636" Subject: Re: [RESEND PATCH v6 2/6] i2c: designware: refactoring of the i2c-designware To: Luis Oliveira , wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com, andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <6fabfa1a657d6bac108bd91f8ac33295a5086987.1488383202.git.lolivei@synopsys.com> Cc: Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com, CARLOS.PALMINHA@synopsys.com From: Jarkko Nikula Message-ID: Date: Thu, 2 Mar 2017 15:40:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <6fabfa1a657d6bac108bd91f8ac33295a5086987.1488383202.git.lolivei@synopsys.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/01/17 17:59, Luis Oliveira wrote: > - Factor out all _master() part of code from i2c-designware-core > and i2c-designware-platdrv to separate functions. > - Standardize all code related with MASTER mode. > - I have to take off DW_IC_INTR_TX_EMPTY from DW_IC_INTR_DEFAULT_MASK > because it is master specific. > > The purpose of this is to prepare the controller to have is I2C MASTER > flow in a separate driver. To do this first all the > functions/definitions related to the MASTER flow were identified. > > Signed-off-by: Luis Oliveira > Acked-by: Andy Shevchenko > --- > V5->v6 > - Removed the __func__ of dev_dbg prints > - Fix i2c_dw_configure_master() to accept dw_i2c_dev * > > drivers/i2c/busses/i2c-designware-core.c | 56 +++++++++++++++++------------ > drivers/i2c/busses/i2c-designware-platdrv.c | 31 +++++++++------- > 2 files changed, 52 insertions(+), 35 deletions(-) > Acked-by: Jarkko Nikula