From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE586C2D0B1 for ; Thu, 6 Feb 2020 06:21:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8CE5620838 for ; Thu, 6 Feb 2020 06:21:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727818AbgBFGVy (ORCPT ); Thu, 6 Feb 2020 01:21:54 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:56064 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725809AbgBFGVy (ORCPT ); Thu, 6 Feb 2020 01:21:54 -0500 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0166AV64013341 for ; Thu, 6 Feb 2020 01:21:53 -0500 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2xyhmmkpur-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 06 Feb 2020 01:21:52 -0500 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 6 Feb 2020 06:21:50 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 6 Feb 2020 06:21:46 -0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0166LkaH56033382 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 6 Feb 2020 06:21:46 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 00CEBA4040; Thu, 6 Feb 2020 06:21:46 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9C5A0A4053; Thu, 6 Feb 2020 06:21:43 +0000 (GMT) Received: from [9.85.90.213] (unknown [9.85.90.213]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 6 Feb 2020 06:21:43 +0000 (GMT) Subject: Re: [PATCH 2/5] mm/memremap_pages: Introduce memremap_compat_align() To: Dan Williams , Michael Ellerman Cc: linux-nvdimm , Jeff Moyer , Benjamin Herrenschmidt , Paul Mackerras , Vishal L Verma , Christoph Hellwig , Linux Kernel Mailing List , linuxppc-dev References: <158041475480.3889308.655103391935006598.stgit@dwillia2-desk3.amr.corp.intel.com> <158041476763.3889308.13149849631980018039.stgit@dwillia2-desk3.amr.corp.intel.com> <875zgl3fa9.fsf@mpe.ellerman.id.au> From: "Aneesh Kumar K.V" Date: Thu, 6 Feb 2020 11:51:42 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 20020606-4275-0000-0000-0000039E6A61 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20020606-4276-0000-0000-000038B296A0 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-02-05_06:2020-02-04,2020-02-05 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=985 bulkscore=0 impostorscore=0 mlxscore=0 priorityscore=1501 clxscore=1015 phishscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002060048 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/6/20 11:21 AM, Dan Williams wrote: .... >>> >>> Link: http://lore.kernel.org/r/CAPcyv4gBGNP95APYaBcsocEa50tQj9b5h__83vgngjq3ouGX_Q@mail.gmail.com >>> Reported-by: Aneesh Kumar K.V >>> Reported-by: Jeff Moyer >>> Cc: Benjamin Herrenschmidt >>> Cc: Paul Mackerras >>> Cc: Michael Ellerman >>> Signed-off-by: Dan Williams >>> --- >>> arch/powerpc/include/asm/io.h | 10 ++++++++++ >>> drivers/nvdimm/pfn_devs.c | 2 +- >>> include/linux/io.h | 23 +++++++++++++++++++++++ >>> include/linux/mmzone.h | 1 + >>> 4 files changed, 35 insertions(+), 1 deletion(-) >> >> The powerpc change here looks fine to me. >> >> Acked-by: Michael Ellerman (powerpc) > > Thanks Michael, unfortunately the kbuild robot just woke up and said > that mips does not like including mmzone.h from io.h. The > entanglements look intractable. > > Is there a file I can stash a strong definition of > memremap_compat_align(), maybe arch/powerpc/mm/mem.c? Then I can put a > generic __weak definition in mm/memremap.c rather than play header > file include games. > arch/powerpc/mm/ioremap.c ? -aneesh