From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EC40EB64DB for ; Sat, 17 Jun 2023 07:33:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346184AbjFQHdK (ORCPT ); Sat, 17 Jun 2023 03:33:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234647AbjFQHdI (ORCPT ); Sat, 17 Jun 2023 03:33:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7340297A; Sat, 17 Jun 2023 00:33:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 48C5260A73; Sat, 17 Jun 2023 07:33:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9FC93C433C8; Sat, 17 Jun 2023 07:33:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686987185; bh=ptIUt8Giy+UX+V4UbH0FVrL7yqzDEK1ImVjFGbruads=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=UD5QZAgungDxwbEEdJFqJAfYhiB0+n5c2GA+6l9UBZ4eiJksYv8Kh+bHX21yOZuYr nmlR2AqeiR+JYFXlyEkfPtxKdUankyhT+z3CXp8YCUnHmreMPFZhTmJryzdyEVMdkY bv4mekIv+PSTdkydKWM1q95Nlkn6HNOn/Pga5scSTlvVqz0444m/l5UALC0jsto92Y laourqKUK5FmeHZsbDFP4AOgC/+1aMsS4nKxnKeKOBu2adlOPNtrRHQVtw6nhj5Oxm YlmHaNDEC1peE9xdVgUX8K3FxprHNW5KghxoCp75Z/xB72sYTUS4jhusSvgY4YT3DI AqEkwiXyQdGnQ== Message-ID: Date: Sat, 17 Jun 2023 09:32:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: =?UTF-8?Q?Re=3a_=5bPATCH_1/3=5d_dt-bindings=3a_can=3a_xilinx=5fcan?= =?UTF-8?B?OiBBZGQgRUNDIHByb3BlcnR5IOKAmHhsbngsaGFzLWVjY+KAmQ==?= Content-Language: en-US From: Krzysztof Kozlowski To: "Goud, Srinivas" , Marc Kleine-Budde Cc: "wg@grandegger.com" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "gcnu.goud@gmail.com" , "git (AMD-Xilinx)" , "michal.simek@xilinx.com" , "linux-can@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" References: <1686570177-2836108-1-git-send-email-srinivas.goud@amd.com> <1686570177-2836108-2-git-send-email-srinivas.goud@amd.com> <20230613-outskirts-dove-e3e39b096647-mkl@pengutronix.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/06/2023 13:11, Krzysztof Kozlowski wrote: > On 14/06/2023 12:22, Goud, Srinivas wrote: >> Hi, >> >>> -----Original Message----- >>> From: Marc Kleine-Budde >>> Sent: Tuesday, June 13, 2023 1:23 PM >>> To: Goud, Srinivas >>> Cc: wg@grandegger.com; davem@davemloft.net; edumazet@google.com; >>> kuba@kernel.org; pabeni@redhat.com; gcnu.goud@gmail.com; git (AMD- >>> Xilinx) ; michal.simek@xilinx.com; linux-can@vger.kernel.org; >>> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org >>> Subject: Re: [PATCH 1/3] dt-bindings: can: xilinx_can: Add ECC property >>> ‘xlnx,has-ecc’ >>> >>> On 12.06.2023 17:12:55, Srinivas Goud wrote: >>>> ECC feature added to Tx and Rx FIFO’s for Xilinx CAN Controller. >>>> Part of this feature configuration and counter registers added in IP >>>> for 1bit/2bit ECC errors. >>>> Please find more details in PG096 v5.1 document. >>>> >>>> xlnx,has-ecc is optional property and added to Xilinx CAN Controller >>>> node if ECC block enabled in the HW. >>>> >>>> Signed-off-by: Srinivas Goud >>> >>> Is there a way to introspect the IP core to check if this feature is compiled in? >> There is no way(IP registers) to indicate whether ECC feature is enabled or not. > > Isn't this then deductible from compatible? Your binding claims it is > only for AXI CAN, so xlnx,axi-can-1.00.a, even though you did not > restrict it in the binding. BTW, this is not an ACK, because this was not tested by automation. I don't understand why get_maintainers.pl are so tricky to use, but nevertheless I require resend to satisfy automation. Best regards, Krzysztof