* [PATCH] platform/x86: fix intel_punit_ipc.c build errors
@ 2018-08-15 16:12 Randy Dunlap
2018-08-17 11:00 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2018-08-15 16:12 UTC (permalink / raw)
To: LKML, Platform Driver; +Cc: Zha Qipeng, Darren Hart, Andy Shevchenko
From: Randy Dunlap <rdunlap@infradead.org>
Fix build errors by #including <linux/io.h>.
../drivers/platform/x86/intel_punit_ipc.c: In function 'ipc_read_status':
../drivers/platform/x86/intel_punit_ipc.c:55:2: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
return readl(ipcdev->base[type][BASE_IFACE]);
../drivers/platform/x86/intel_punit_ipc.c: In function 'ipc_write_cmd':
../drivers/platform/x86/intel_punit_ipc.c:60:2: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration]
writel(cmd, ipcdev->base[type][BASE_IFACE]);
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Zha Qipeng <qipeng.zha@intel.com>
Cc: platform-driver-x86@vger.kernel.org
---
Found in linux-next but applies to current mainline also.
drivers/platform/x86/intel_punit_ipc.c | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20180815.orig/drivers/platform/x86/intel_punit_ipc.c
+++ linux-next-20180815/drivers/platform/x86/intel_punit_ipc.c
@@ -18,6 +18,7 @@
#include <linux/bitops.h>
#include <linux/device.h>
#include <linux/interrupt.h>
+#include <linux/io.h>
#include <linux/platform_device.h>
#include <asm/intel_punit_ipc.h>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/x86: fix intel_punit_ipc.c build errors
2018-08-15 16:12 [PATCH] platform/x86: fix intel_punit_ipc.c build errors Randy Dunlap
@ 2018-08-17 11:00 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2018-08-17 11:00 UTC (permalink / raw)
To: Randy Dunlap, Arnd Bergmann
Cc: LKML, Platform Driver, Zha Qipeng, Darren Hart, Andy Shevchenko
On Wed, Aug 15, 2018 at 7:12 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors by #including <linux/io.h>.
>
> ../drivers/platform/x86/intel_punit_ipc.c: In function 'ipc_read_status':
> ../drivers/platform/x86/intel_punit_ipc.c:55:2: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
> return readl(ipcdev->base[type][BASE_IFACE]);
> ../drivers/platform/x86/intel_punit_ipc.c: In function 'ipc_write_cmd':
> ../drivers/platform/x86/intel_punit_ipc.c:60:2: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration]
> writel(cmd, ipcdev->base[type][BASE_IFACE]);
>
Thanks, pushed to our for-next queue, with Fixes tag appended.
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Zha Qipeng <qipeng.zha@intel.com>
> Cc: platform-driver-x86@vger.kernel.org
> ---
> Found in linux-next but applies to current mainline also.
>
> drivers/platform/x86/intel_punit_ipc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20180815.orig/drivers/platform/x86/intel_punit_ipc.c
> +++ linux-next-20180815/drivers/platform/x86/intel_punit_ipc.c
> @@ -18,6 +18,7 @@
> #include <linux/bitops.h>
> #include <linux/device.h>
> #include <linux/interrupt.h>
> +#include <linux/io.h>
> #include <linux/platform_device.h>
> #include <asm/intel_punit_ipc.h>
>
>
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-17 11:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-15 16:12 [PATCH] platform/x86: fix intel_punit_ipc.c build errors Randy Dunlap
2018-08-17 11:00 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).