From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C4CDECDFB8 for ; Mon, 23 Jul 2018 03:09:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 388ED20779 for ; Mon, 23 Jul 2018 03:09:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="VTDiuCjO"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="S1p7QWdG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 388ED20779 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728176AbeGWEIr (ORCPT ); Mon, 23 Jul 2018 00:08:47 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:52584 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725796AbeGWEIr (ORCPT ); Mon, 23 Jul 2018 00:08:47 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 5223B607B9; Mon, 23 Jul 2018 03:09:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1532315387; bh=vwLM4b8H4b9FbD7v36nJJth5IDzQhmn/BFCkMtpO3EI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=VTDiuCjON5Y4dYn+AW0L3uSq6+bGKvHIpA7alndCp4UZXbd5GULGJqXfjE6HPhV7Q 8GcWnT1U8vSYWSNA1CdjQM+WZl8nloKHTX5sYyivwqa7TRfUBnbe3yBb6Waazvff7+ eXCeg3qAaHSd/ndNjcecoI5IrlikqBttOTmYMZQc= Received: from [10.206.24.39] (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: asutoshd@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 69F4B60328; Mon, 23 Jul 2018 03:09:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1532315385; bh=vwLM4b8H4b9FbD7v36nJJth5IDzQhmn/BFCkMtpO3EI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=S1p7QWdG1g3zpPWAZZGsvVQ8jckcdjnWlmPqvdTR81USE6QbHArVhB9+SvFz1N+dE OdRcYTSASkv9si8Um/zEwCK9VyAOhurjb+ztE15GaufTc5L/V7AGdYFHTFOcNboaZZ +2oyofW2iv/9G+8xxtja6uPPfG2D8k3TuSLtPwCg= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 69F4B60328 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=asutoshd@codeaurora.org Subject: Re: [PATCH v1 4/9] scsi: ufs: add option to change default UFS power management level To: Adrian Hunter , subhashj@codeaurora.org, cang@codeaurora.org, vivek.gautam@codeaurora.org, rnayak@codeaurora.org, vinholikatti@gmail.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, Venkat Gopalakrishnan , Rob Herring , Mark Rutland , Mathieu Malaterre , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <0673f807-bc3c-e401-ae12-07bfafb55bf7@intel.com> From: "Asutosh Das (asd)" Message-ID: Date: Mon, 23 Jul 2018 08:39:38 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <0673f807-bc3c-e401-ae12-07bfafb55bf7@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/11/2018 4:20 PM, Adrian Hunter wrote: > On 06/07/18 15:30, Asutosh Das wrote: >> From: Subhash Jadavani >> >> UFS device and link can be put in multiple different low power modes hence >> UFS driver supports multiple different low power modes. By default UFS >> driver selects the default (optimal) low power mode (which gives moderate >> power savings and have relatively less enter and exit latencies) but >> we might have to tune this default power mode for different chipset >> platforms to meet the low power requirements/goals. Hence this patch >> adds option to change default UFS low power mode (level). >> >> Signed-off-by: Subhash Jadavani >> Signed-off-by: Venkat Gopalakrishnan >> Signed-off-by: Can Guo >> Signed-off-by: Asutosh Das >> --- >> .../devicetree/bindings/ufs/ufshcd-pltfrm.txt | 11 ++++++++ >> drivers/scsi/ufs/ufshcd-pltfrm.c | 14 +++++++++++ >> drivers/scsi/ufs/ufshcd.c | 29 +++++++++++++++------- >> drivers/scsi/ufs/ufshcd.h | 4 +-- >> 4 files changed, 47 insertions(+), 11 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt >> index c39dfef..f564d9a 100644 >> --- a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt >> +++ b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt >> @@ -38,6 +38,15 @@ Optional properties: >> defined or a value in the array is "0" then it is assumed >> that the frequency is set by the parent clock or a >> fixed rate clock source. >> +- rpm-level : UFS Runtime power management level. Following PM levels are supported: >> + 0 - Both UFS device and Link in active state (Highest power consumption) >> + 1 - UFS device in active state but Link in Hibern8 state >> + 2 - UFS device in Sleep state but Link in active state >> + 3 - UFS device in Sleep state and Link in hibern8 state (default PM level) >> + 4 - UFS device in Power-down state and Link in Hibern8 state >> + 5 - UFS device in Power-down state and Link in OFF state (Lowest power consumption) >> +- spm-level : UFS System power management level. Allowed PM levels are same as rpm-level. >> + >> -lanes-per-direction : number of lanes available per direction - either 1 or 2. >> Note that it is assume same number of lanes is used both >> directions at once. If not specified, default is 2 lanes per direction. >> @@ -66,4 +75,6 @@ Example: >> freq-table-hz = <100000000 200000000>, <0 0>, <0 0>; >> phys = <&ufsphy1>; >> phy-names = "ufsphy"; >> + rpm-level = <3>; >> + spm-level = <5>; >> }; >> diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c >> index e82bde0..7dba799 100644 >> --- a/drivers/scsi/ufs/ufshcd-pltfrm.c >> +++ b/drivers/scsi/ufs/ufshcd-pltfrm.c >> @@ -221,6 +221,19 @@ static int ufshcd_parse_regulator_info(struct ufs_hba *hba) >> return err; >> } >> >> +static void ufshcd_parse_pm_levels(struct ufs_hba *hba) >> +{ >> + struct device *dev = hba->dev; >> + struct device_node *np = dev->of_node; >> + >> + if (np) { >> + if (of_property_read_u32(np, "rpm-level", &hba->rpm_lvl)) >> + hba->rpm_lvl = -1; >> + if (of_property_read_u32(np, "spm-level", &hba->spm_lvl)) >> + hba->spm_lvl = -1; > > These are generically useful to all UFSHC drivers, so they should be > device_property_read_u32() and they should be read for all drivers not just > pltfrm i.e. move this code into ufshcd.c > >> + } >> +} >> + >> #ifdef CONFIG_PM >> /** >> * ufshcd_pltfrm_suspend - suspend power management function >> @@ -340,6 +353,7 @@ int ufshcd_pltfrm_init(struct platform_device *pdev, >> goto dealloc_host; >> } >> >> + ufshcd_parse_pm_levels(hba); >> pm_runtime_set_active(&pdev->dev); >> pm_runtime_enable(&pdev->dev); >> >> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c >> index b03f3ea..e950204 100644 >> --- a/drivers/scsi/ufs/ufshcd.c >> +++ b/drivers/scsi/ufs/ufshcd.c >> @@ -192,6 +192,14 @@ struct ufs_pm_lvl_states ufs_pm_lvl_states[] = { >> return UFS_PM_LVL_0; >> } >> >> +static inline bool ufshcd_is_valid_pm_lvl(int lvl) >> +{ >> + if (lvl >= 0 && lvl < ARRAY_SIZE(ufs_pm_lvl_states)) >> + return true; >> + else >> + return false; >> +} >> + >> static struct ufs_dev_fix ufs_fixups[] = { >> /* UFS cards deviations table */ >> UFS_FIX(UFS_VENDOR_SAMSUNG, UFS_ANY_MODEL, >> @@ -8051,16 +8059,19 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq) >> } >> >> /* >> - * Set the default power management level for runtime and system PM. >> - * Default power saving mode is to keep UFS link in Hibern8 state >> - * and UFS device in sleep state. >> + * If rpm_lvl and and spm_lvl are not already set to valid levels, >> + * set the default power management level for UFS runtime and system >> + * suspend. Default power saving mode selected is keeping UFS link in >> + * Hibern8 state and UFS device in sleep state. >> */ >> - hba->rpm_lvl = ufs_get_desired_pm_lvl_for_dev_link_state( >> - UFS_SLEEP_PWR_MODE, >> - UIC_LINK_HIBERN8_STATE); >> - hba->spm_lvl = ufs_get_desired_pm_lvl_for_dev_link_state( >> - UFS_SLEEP_PWR_MODE, >> - UIC_LINK_HIBERN8_STATE); >> + if (!ufshcd_is_valid_pm_lvl(hba->rpm_lvl)) >> + hba->rpm_lvl = ufs_get_desired_pm_lvl_for_dev_link_state( >> + UFS_SLEEP_PWR_MODE, >> + UIC_LINK_HIBERN8_STATE); >> + if (!ufshcd_is_valid_pm_lvl(hba->spm_lvl)) >> + hba->spm_lvl = ufs_get_desired_pm_lvl_for_dev_link_state( >> + UFS_SLEEP_PWR_MODE, >> + UIC_LINK_HIBERN8_STATE); >> >> /* Set the default auto-hiberate idle timer value to 150 ms */ >> if (hba->capabilities & MASK_AUTO_HIBERN8_SUPPORT) { >> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h >> index e996a08..a2e1d5c 100644 >> --- a/drivers/scsi/ufs/ufshcd.h >> +++ b/drivers/scsi/ufs/ufshcd.h >> @@ -526,9 +526,9 @@ struct ufs_hba { >> enum ufs_dev_pwr_mode curr_dev_pwr_mode; >> enum uic_link_state uic_link_state; >> /* Desired UFS power management level during runtime PM */ >> - enum ufs_pm_level rpm_lvl; >> + int rpm_lvl; >> /* Desired UFS power management level during system PM */ >> - enum ufs_pm_level spm_lvl; >> + int spm_lvl; >> struct device_attribute rpm_lvl_attr; >> struct device_attribute spm_lvl_attr; >> int pm_op_in_progress; >> > Thanks. I'll make the changes and push it in v2. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project