From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AA29C43381 for ; Thu, 18 Mar 2021 16:00:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39E2864F2B for ; Thu, 18 Mar 2021 16:00:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231936AbhCRP7z (ORCPT ); Thu, 18 Mar 2021 11:59:55 -0400 Received: from mga18.intel.com ([134.134.136.126]:50906 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231927AbhCRP7d (ORCPT ); Thu, 18 Mar 2021 11:59:33 -0400 IronPort-SDR: h6IIETYp5BVASCxI0v9xPeSs/8Q1QRjwbc1f+FR7nY8DDrZ/zwGA5fERO1fQJzWZj3VkvLWjv0 irj7+THjQoMw== X-IronPort-AV: E=McAfee;i="6000,8403,9927"; a="177304282" X-IronPort-AV: E=Sophos;i="5.81,259,1610438400"; d="scan'208";a="177304282" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2021 08:59:30 -0700 IronPort-SDR: kKWFS1pQmad2W49zFYAOG3ZxMvGCyh3Me0VkpNZIi7D+3z5rwfmc2LOnv0QgzMFM+kR/tdiT/+ a9w/Ya8Irwgw== X-IronPort-AV: E=Sophos;i="5.81,259,1610438400"; d="scan'208";a="450527286" Received: from yyu32-mobl1.amr.corp.intel.com (HELO [10.209.36.121]) ([10.209.36.121]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2021 08:59:29 -0700 Subject: Re: [PATCH v23 21/28] mm: Re-introduce vm_flags to do_mmap() To: Borislav Petkov Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , Haitao Huang , Peter Collingbourne , Andrew Morton References: <20210316151054.5405-1-yu-cheng.yu@intel.com> <20210316151054.5405-22-yu-cheng.yu@intel.com> <20210318114232.GD19570@zn.tnic> From: "Yu, Yu-cheng" Message-ID: Date: Thu, 18 Mar 2021 08:59:28 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210318114232.GD19570@zn.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/18/2021 4:42 AM, Borislav Petkov wrote: > On Tue, Mar 16, 2021 at 08:10:47AM -0700, Yu-cheng Yu wrote: >> There was no more caller passing vm_flags to do_mmap(), and vm_flags was >> removed from the function's input by: >> >> commit 45e55300f114 ("mm: remove unnecessary wrapper function do_mmap_pgoff()"). >> >> There is a new user now. Shadow stack allocation passes VM_SHSTK to >> do_mmap(). Re-introduce vm_flags to do_mmap(), but without the old wrapper >> do_mmap_pgoff(). > > Why does this matter at all? > > $ git grep do_mmap_pgoff > $ > Right, do_mmap_pgoff() was removed by commit 45e55300f114. This patch does not add back the wrapper. Instead, add vm_flags to do_mmap(). Please advice if I misunderstand the question. Thanks, Yu-cheng