From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25DAEC3F2C6 for ; Tue, 3 Mar 2020 08:34:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 07521215A4 for ; Tue, 3 Mar 2020 08:34:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727193AbgCCIey (ORCPT ); Tue, 3 Mar 2020 03:34:54 -0500 Received: from mx2.suse.de ([195.135.220.15]:33414 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725879AbgCCIey (ORCPT ); Tue, 3 Mar 2020 03:34:54 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 58FC5AE79; Tue, 3 Mar 2020 08:34:52 +0000 (UTC) Subject: Re: [PATCH 0/5] Simplify /proc/$pid/maps implementation To: Matthew Wilcox , linux-fsdevel@vger.kernel.org, Alexey Dobriyan Cc: linux-kernel@vger.kernel.org, "linux-mm@kvack.org" References: <20200229165910.24605-1-willy@infradead.org> From: Vlastimil Babka Message-ID: Date: Tue, 3 Mar 2020 09:34:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200229165910.24605-1-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/29/20 5:59 PM, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" Re: subject, it's not only maps, but also smaps, smaps_rollu, numa_maps > Back in 2005, we merged a patch from Akamai that sped up /proc/$pid/maps > by using f_version to stash the user virtual address that we'd just > displayed. That wasn't necessary; we can just use the private *ppos for > the same purpose. There have also been some other odd choices made over > the years that use the seq_file infrastructure in some non-idiomatic ways. > > Tested by using 'dd' with various different 'bs=' parameters to check that > calling ->start, ->stop and ->next at various offsets work as expected. > > Matthew Wilcox (Oracle) (5): > proc: Inline vma_stop into m_stop > proc: remove m_cache_vma > proc: Use ppos instead of m->version > seq_file: Remove m->version > proc: Inline m_next_vma into m_next For all of them: Acked-by: Vlastimil Babka Thanks! > fs/proc/task_mmu.c | 95 +++++++++++++--------------------------- > fs/seq_file.c | 28 ------------ > include/linux/seq_file.h | 1 - > 3 files changed, 31 insertions(+), 93 deletions(-) > > base-commit: d5226fa6dbae0569ee43ecfc08bdcd6770fc4755 >