From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936005AbcKQR1Y (ORCPT ); Thu, 17 Nov 2016 12:27:24 -0500 Received: from userp1050.oracle.com ([156.151.31.82]:35844 "EHLO userp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932596AbcKQR1U (ORCPT ); Thu, 17 Nov 2016 12:27:20 -0500 Subject: Re: [PATCH v2] xen/gntdev: Use mempolicy instead of VM_IO flag to avoid NUMA balancing To: Olaf Hering References: <1479318378-595-1-git-send-email-boris.ostrovsky@oracle.com> <20161117112843.GA19761@aepfle.de> Cc: david.vrabel@citrix.com, jgross@suse.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org From: Boris Ostrovsky Message-ID: Date: Thu, 17 Nov 2016 11:01:15 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161117112843.GA19761@aepfle.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RfKDiS815O8b2FFB4iDXQwR5o4qUD5jkf" X-Source-IP: userp1040.oracle.com [156.151.31.81] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RfKDiS815O8b2FFB4iDXQwR5o4qUD5jkf Content-Type: multipart/mixed; boundary="pgFScQloRAQFWNO9g6GwA6A2nLfeIes9M"; protected-headers="v1" From: Boris Ostrovsky To: Olaf Hering Cc: david.vrabel@citrix.com, jgross@suse.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Message-ID: Subject: Re: [PATCH v2] xen/gntdev: Use mempolicy instead of VM_IO flag to avoid NUMA balancing References: <1479318378-595-1-git-send-email-boris.ostrovsky@oracle.com> <20161117112843.GA19761@aepfle.de> In-Reply-To: <20161117112843.GA19761@aepfle.de> --pgFScQloRAQFWNO9g6GwA6A2nLfeIes9M Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/17/2016 06:28 AM, Olaf Hering wrote: > On Wed, Nov 16, Boris Ostrovsky wrote: > >> Unfortunately I haven't been able to trigger NUMA balancing >> so while I tested this in general I am not sure I actually >> exercised the code path. > Thanks for the patch! > > Would be nice to actually test the code path which caused the initial > addition of VM_IO. I think I lack the hardware to excersise them. To trip the original bug is even more difficult than to trigger NUMA balancing. It was very sensitive to memory allocation. > > > In my 4.4 based sources I get the following unresolved symbols. If that= > happens to work in mainline the failures should at least be considered > during backporting of this proposed patch to the stable trees. > > ERROR: "__mpol_dup" [drivers/xen/xen-gntdev.ko] undefined! > ERROR: "get_task_policy" [drivers/xen/xen-gntdev.ko] undefined! > > Appearently these symbols lack just an EXPORT_SYMBOL_GPL. I just built 4.4.11 with this patch applied and haven't had any problems.= -boris --pgFScQloRAQFWNO9g6GwA6A2nLfeIes9M-- --RfKDiS815O8b2FFB4iDXQwR5o4qUD5jkf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYLdRLAAoJEIredpCGysGyTTkP/03Q6ruyNzifFm4jLpkgulZq GtIUPauIs5dBVtFbRNhPkzWZ1NMcxZfisb52vIKC1l0t22tT5PIdLv9oV9EAQlcO KXrr4mM76CXHx2LfbeZL1EvkUQwVmNy+O/iDP6dhG5OoIy7ldlAe/e0aRi7SAR5K cRKO+ePxRM6XaT/jtXp+M0/KWaf1e+7/qhoQxbXhcWRcq238IMUduqQ10TnaeBUZ eve3U5owG8v0KtwvtGuQad4fAMTjMpN1z+QjUbdoguqJ4KMiHjfnnzPBy58WxxEG 7u+hQyKgznPrU9AmVeRNg01Or89WAGYUtBibKpMZVCnWU9LKpYVLqvlBhW3eT+oO 5zU7KFrNGAsow7C4N3VIWE0915eLAcwKk+gGGvYAjtJ2kvDBMzJ4EbcocyleT/g6 wxRjbYjD2QuLHsTA+c8UAucKkvxe+7mvlzsce06j3G19uXUIjJbQUssnewKqg6E5 zsri2lHr9oNAznPgWqbVYKdNuI5E5+v/gyBCNhzHHPq00XAEGqO3mVF7WYm7pwQG 0IIXaR1gi3M6ybw2zx+WdldhoibWhfbZN49oHv8ZyXRR9z2p4d/pJiOh0YmPumpf XcDbERf1QsQtnwrHEcwMHbmKK1vcoO/3Y7xiQiuibvRo7QCr4VJ8nkfMdAA2rgxd sEk6T7VnY1L/jwTOXs1O =tGB6 -----END PGP SIGNATURE----- --RfKDiS815O8b2FFB4iDXQwR5o4qUD5jkf--