From: Dave Jiang <dave.jiang@intel.com>
To: YueHaibing <yuehaibing@huawei.com>,
vkoul@kernel.org, dan.j.williams@intel.com
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] dmaengine: idxd: remove set but not used variable 'idxd_cdev'
Date: Mon, 10 Feb 2020 09:35:35 -0700 [thread overview]
Message-ID: <af481087-388d-fe65-6a42-af5cccb9a46b@intel.com> (raw)
In-Reply-To: <20200210151855.55044-1-yuehaibing@huawei.com>
On 2/10/20 8:18 AM, YueHaibing wrote:
> drivers/dma/idxd/cdev.c: In function idxd_cdev_open:
> drivers/dma/idxd/cdev.c:77:20: warning:
> variable idxd_cdev set but not used [-Wunused-but-set-variable]
>
> commit 42d279f9137a ("dmaengine: idxd: add char driver to
> expose submission portal to userland") involed this.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/dma/idxd/cdev.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c
> index 1d73478..8dfdbe3 100644
> --- a/drivers/dma/idxd/cdev.c
> +++ b/drivers/dma/idxd/cdev.c
> @@ -74,12 +74,10 @@ static int idxd_cdev_open(struct inode *inode, struct file *filp)
> struct idxd_device *idxd;
> struct idxd_wq *wq;
> struct device *dev;
> - struct idxd_cdev *idxd_cdev;
>
> wq = inode_wq(inode);
> idxd = wq->idxd;
> dev = &idxd->pdev->dev;
> - idxd_cdev = &wq->idxd_cdev;
>
> dev_dbg(dev, "%s called\n", __func__);
>
>
next prev parent reply other threads:[~2020-02-10 16:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 15:18 [PATCH -next] dmaengine: idxd: remove set but not used variable 'idxd_cdev' YueHaibing
2020-02-10 16:35 ` Dave Jiang [this message]
2020-02-13 14:34 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af481087-388d-fe65-6a42-af5cccb9a46b@intel.com \
--to=dave.jiang@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).