From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Russell King" <linux@armlinux.org.uk>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>, "Guo Ren" <guoren@kernel.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Greg Ungerer" <gerg@linux-m68k.org>,
"Joshua Thompson" <funaho@jurai.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Sebastian Reichel" <sre@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Greentime Hu" <green.hu@gmail.com>,
"Vincent Chen" <deanbo422@gmail.com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Helge Deller" <deller@gmx.de>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Paul Mackerras" <paulus@samba.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Rich Felker" <dalias@libc.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"the arch/x86 maintainers" <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Juergen Gross" <jgross@suse.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Len Brown" <lenb@kernel.org>,
"Santosh Shilimkar" <ssantosh@kernel.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>, "Pavel Machek" <pavel@ucw.cz>,
"Lee Jones" <lee.jones@linaro.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-m68k@lists.linux-m68k.org,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org,
"Linux-sh list" <linux-sh@vger.kernel.org>,
xen-devel@lists.xenproject.org,
"ACPI Devel Maling List" <linux-acpi@vger.kernel.org>,
"Linux PM" <linux-pm@vger.kernel.org>,
linux-tegra <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v7 03/20] reboot: Print error message if restart handler has duplicated priority
Date: Thu, 14 Apr 2022 01:23:52 +0300 [thread overview]
Message-ID: <af51d9d0-26ba-fc66-05f1-d92ef7172730@collabora.com> (raw)
In-Reply-To: <CAJZ5v0gf1J+yPW14TAdLGLGfO+-2s=r0DDP7d+Rgop3=dB0gaQ@mail.gmail.com>
On 4/13/22 21:48, Rafael J. Wysocki wrote:
> On Tue, Apr 12, 2022 at 1:39 AM Dmitry Osipenko
> <dmitry.osipenko@collabora.com> wrote:
>>
>> Add sanity check which ensures that there are no two restart handlers
>> registered using the same priority. This requirement will become mandatory
>> once all drivers will be converted to the new API and such errors will be
>> fixed.
>>
>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>
> The first two patches in the series are fine with me and there's only
> one minor nit regarding this one (below).
>
>> ---
>> kernel/reboot.c | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/kernel/reboot.c b/kernel/reboot.c
>> index ed4e6dfb7d44..acdae4e95061 100644
>> --- a/kernel/reboot.c
>> +++ b/kernel/reboot.c
>> @@ -182,6 +182,21 @@ static ATOMIC_NOTIFIER_HEAD(restart_handler_list);
>> */
>> int register_restart_handler(struct notifier_block *nb)
>> {
>> + int ret;
>> +
>> + ret = atomic_notifier_chain_register_unique_prio(&restart_handler_list, nb);
>> + if (ret != -EBUSY)
>> + return ret;
>> +
>> + /*
>> + * Handler must have unique priority. Otherwise call order is
>> + * determined by registration order, which is unreliable.
>> + *
>> + * This requirement will become mandatory once all drivers
>> + * will be converted to use new sys-off API.
>> + */
>> + pr_err("failed to register restart handler using unique priority\n");
>
> I would use pr_info() here, because this is not a substantial error AFAICS.
It's indeed not a substantial error so far, but it will become
substantial later on once only unique priorities will be allowed. The
pr_warn() could be a good compromise here, pr_info() is too mild, IMO.
next prev parent reply other threads:[~2022-04-13 22:24 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 23:38 [PATCH v7 00/20] Introduce power-off+restart call chain API Dmitry Osipenko
2022-04-11 23:38 ` [PATCH v7 01/20] notifier: Add blocking_notifier_call_chain_is_empty() Dmitry Osipenko
2022-04-11 23:38 ` [PATCH v7 02/20] notifier: Add atomic/blocking_notifier_chain_register_unique_prio() Dmitry Osipenko
2022-04-11 23:38 ` [PATCH v7 03/20] reboot: Print error message if restart handler has duplicated priority Dmitry Osipenko
2022-04-13 18:48 ` Rafael J. Wysocki
2022-04-13 22:23 ` Dmitry Osipenko [this message]
2022-04-14 11:19 ` Rafael J. Wysocki
2022-04-18 1:29 ` Dmitry Osipenko
2022-04-20 17:36 ` Rafael J. Wysocki
2022-04-11 23:38 ` [PATCH v7 04/20] kernel: Add combined power-off+restart handler call chain API Dmitry Osipenko
2022-04-15 18:14 ` Rafael J. Wysocki
2022-04-18 1:44 ` Dmitry Osipenko
2022-04-20 18:47 ` Rafael J. Wysocki
2022-05-06 14:10 ` Dmitry Osipenko
2022-05-06 14:46 ` Dmitry Osipenko
2022-05-06 15:10 ` Dmitry Osipenko
2022-05-06 15:28 ` Dmitry Osipenko
2022-04-11 23:38 ` [PATCH v7 05/20] ARM: Use do_kernel_power_off() Dmitry Osipenko
2022-04-11 23:38 ` [PATCH v7 06/20] csky: " Dmitry Osipenko
2022-04-11 23:38 ` [PATCH v7 07/20] riscv: " Dmitry Osipenko
2022-04-11 23:38 ` [PATCH v7 08/20] arm64: " Dmitry Osipenko
2022-04-11 23:38 ` [PATCH v7 09/20] parisc: " Dmitry Osipenko
2022-04-11 23:38 ` [PATCH v7 10/20] xen/x86: " Dmitry Osipenko
2022-04-11 23:38 ` [PATCH v7 11/20] powerpc: " Dmitry Osipenko
2022-04-11 23:38 ` [PATCH v7 12/20] m68k: Switch to new sys-off handler API Dmitry Osipenko
2022-04-11 23:38 ` [PATCH v7 13/20] sh: Use do_kernel_power_off() Dmitry Osipenko
2022-04-11 23:38 ` [PATCH v7 14/20] x86: " Dmitry Osipenko
2022-04-11 23:38 ` [PATCH v7 15/20] ia64: " Dmitry Osipenko
2022-04-11 23:38 ` [PATCH v7 16/20] mips: " Dmitry Osipenko
2022-04-12 9:55 ` Dmitry Osipenko
2022-04-11 23:38 ` [PATCH v7 17/20] memory: emif: Use kernel_can_power_off() Dmitry Osipenko
2022-04-12 9:56 ` Dmitry Osipenko
2022-04-11 23:38 ` [PATCH v7 18/20] ACPI: power: Switch to sys-off handler API Dmitry Osipenko
2022-04-11 23:38 ` [PATCH v7 19/20] regulator: pfuze100: Use devm_register_sys_off_handler() Dmitry Osipenko
2022-04-11 23:38 ` [PATCH v7 20/20] reboot: Remove pm_power_off_prepare() Dmitry Osipenko
2022-04-12 7:06 ` [PATCH v7 00/20] Introduce power-off+restart call chain API Geert Uytterhoeven
2022-04-12 9:55 ` Dmitry Osipenko
2022-04-14 18:09 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af51d9d0-26ba-fc66-05f1-d92ef7172730@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=aou@eecs.berkeley.edu \
--cc=benh@kernel.crashing.org \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dalias@libc.org \
--cc=daniel.lezcano@linaro.org \
--cc=dave.hansen@linux.intel.com \
--cc=deanbo422@gmail.com \
--cc=deller@gmx.de \
--cc=funaho@jurai.org \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=green.hu@gmail.com \
--cc=guoren@kernel.org \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jonathanh@nvidia.com \
--cc=krzk@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lenb@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=mingo@redhat.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mpe@ellerman.id.au \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paulus@samba.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=sre@kernel.org \
--cc=ssantosh@kernel.org \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=tsbogend@alpha.franken.de \
--cc=ulf.hansson@linaro.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).