From: David Hildenbrand <david@redhat.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>, linux-mm@kvack.org
Cc: Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/thp: Drop unused trace events hugepage_[invalidate|splitting]
Date: Wed, 12 Jan 2022 10:17:48 +0100 [thread overview]
Message-ID: <af52b95b-dab3-a5d5-0e31-f7e91b16e556@redhat.com> (raw)
In-Reply-To: <1641546351-15109-1-git-send-email-anshuman.khandual@arm.com>
On 07.01.22 10:05, Anshuman Khandual wrote:
> The trace events hugepage_[invalidate|splitting], were added via the commit
> 9e813308a5c1 ("powerpc/thp: Add tracepoints to track hugepage invalidate").
> Afterwards their call sites i.e trace_hugepage_[invalidate|splitting] were
> just dropped off, leaving these trace points unused.
>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
> Cc: Kirill A. Shutemov <kirill@shutemov.name>
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> This applies on v5.16-rc8
>
> trace_hugepage_splitting() dropped via the commit 7aa9a23c69ea
> trace_hugepage_invalidate() dropped via the commit 7900757ce1b4
>
> include/trace/events/thp.h | 36 ------------------------------------
> 1 file changed, 36 deletions(-)
>
> diff --git a/include/trace/events/thp.h b/include/trace/events/thp.h
> index d7fbbe551841..ffa4b37d02a9 100644
> --- a/include/trace/events/thp.h
> +++ b/include/trace/events/thp.h
> @@ -8,24 +8,6 @@
> #include <linux/types.h>
> #include <linux/tracepoint.h>
>
> -TRACE_EVENT(hugepage_invalidate,
> -
> - TP_PROTO(unsigned long addr, unsigned long pte),
> - TP_ARGS(addr, pte),
> - TP_STRUCT__entry(
> - __field(unsigned long, addr)
> - __field(unsigned long, pte)
> - ),
> -
> - TP_fast_assign(
> - __entry->addr = addr;
> - __entry->pte = pte;
> - ),
> -
> - TP_printk("hugepage invalidate at addr 0x%lx and pte = 0x%lx",
> - __entry->addr, __entry->pte)
> -);
> -
> TRACE_EVENT(hugepage_set_pmd,
>
> TP_PROTO(unsigned long addr, unsigned long pmd),
> @@ -65,24 +47,6 @@ TRACE_EVENT(hugepage_update,
>
> TP_printk("hugepage update at addr 0x%lx and pte = 0x%lx clr = 0x%lx, set = 0x%lx", __entry->addr, __entry->pte, __entry->clr, __entry->set)
> );
> -TRACE_EVENT(hugepage_splitting,
> -
> - TP_PROTO(unsigned long addr, unsigned long pte),
> - TP_ARGS(addr, pte),
> - TP_STRUCT__entry(
> - __field(unsigned long, addr)
> - __field(unsigned long, pte)
> - ),
> -
> - TP_fast_assign(
> - __entry->addr = addr;
> - __entry->pte = pte;
> - ),
> -
> - TP_printk("hugepage splitting at addr 0x%lx and pte = 0x%lx",
> - __entry->addr, __entry->pte)
> -);
> -
> #endif /* _TRACE_THP_H */
>
> /* This part must be outside protection */
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2022-01-12 9:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 9:05 [PATCH] mm/thp: Drop unused trace events hugepage_[invalidate|splitting] Anshuman Khandual
2022-01-12 9:17 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af52b95b-dab3-a5d5-0e31-f7e91b16e556@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=anshuman.khandual@arm.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).