From: Chao Yu <chao@kernel.org>
To: Daniel Rosenberg <drosen@google.com>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <yuchao0@huawei.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-f2fs-devel@lists.sourceforge.net
Cc: linux-doc@vger.kernel.org, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
kernel-team@android.com
Subject: Re: [f2fs-dev] [PATCH v4 2/3] f2fs: include charset encoding information in the superblock
Date: Sun, 28 Jul 2019 08:45:51 +0800 [thread overview]
Message-ID: <af60ce55-1a29-d8da-81e4-77c880f4a0d0@kernel.org> (raw)
In-Reply-To: <20190723230529.251659-3-drosen@google.com>
On 2019-7-24 7:05, Daniel Rosenberg via Linux-f2fs-devel wrote:
> Add charset encoding to f2fs to support casefolding. It is modeled after
> the same feature introduced in commit c83ad55eaa91 ("ext4: include charset
> encoding information in the superblock")
>
> Currently this is not compatible with encryption, similar to the current
> ext4 imlpementation. This will change in the future.
>
> From the ext4 patch:
> """
> The s_encoding field stores a magic number indicating the encoding
> format and version used globally by file and directory names in the
> filesystem. The s_encoding_flags defines policies for using the charset
> encoding, like how to handle invalid sequences. The magic number is
> mapped to the exact charset table, but the mapping is specific to ext4.
> Since we don't have any commitment to support old encodings, the only
> encoding I am supporting right now is utf8-12.1.0.
>
> The current implementation prevents the user from enabling encoding and
> per-directory encryption on the same filesystem at the same time. The
> incompatibility between these features lies in how we do efficient
> directory searches when we cannot be sure the encryption of the user
> provided fname will match the actual hash stored in the disk without
> decrypting every directory entry, because of normalization cases. My
> quickest solution is to simply block the concurrent use of these
> features for now, and enable it later, once we have a better solution.
> """
>
> Signed-off-by: Daniel Rosenberg <drosen@google.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
next prev parent reply other threads:[~2019-07-28 0:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 23:05 [PATCH v4 0/3] Casefolding in F2FS Daniel Rosenberg
2019-07-23 23:05 ` [PATCH v4 1/3] fs: Reserve flag for casefolding Daniel Rosenberg
2019-07-28 0:36 ` [f2fs-dev] " Chao Yu
2019-07-23 23:05 ` [PATCH v4 2/3] f2fs: include charset encoding information in the superblock Daniel Rosenberg
2019-07-28 0:45 ` Chao Yu [this message]
2019-07-23 23:05 ` [PATCH v4 3/3] f2fs: Support case-insensitive file name lookups Daniel Rosenberg
2019-07-28 0:55 ` [f2fs-dev] " Chao Yu
2019-07-29 6:27 ` Jaegeuk Kim
2019-07-29 7:22 ` Chao Yu
2019-07-29 14:57 ` Chao Yu
2019-07-31 17:57 ` Nathan Chancellor
2019-08-01 1:11 ` Chao Yu
2019-08-01 4:05 ` Jaegeuk Kim
2019-08-21 13:15 ` [f2fs-dev] " Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af60ce55-1a29-d8da-81e4-77c880f4a0d0@kernel.org \
--to=chao@kernel.org \
--cc=corbet@lwn.net \
--cc=drosen@google.com \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).