From: David Hildenbrand <david@redhat.com>
To: Li Zetao <lizetao1@huawei.com>,
mst@redhat.com, jasowang@redhat.com, pbonzini@redhat.com,
stefanha@redhat.com, axboe@kernel.dk, kraxel@redhat.com,
ericvh@gmail.com, lucho@ionkov.net, asmadeus@codewreck.org,
linux_oss@crudebyte.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
rusty@rustcorp.com.au
Cc: virtualization@lists.linux-foundation.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH 2/4] virtio-mem: Fix probe failed when modprobe virtio_mem
Date: Mon, 28 Nov 2022 09:22:40 +0100 [thread overview]
Message-ID: <af62e7fe-d848-acb8-ca77-cdf01022b8de@redhat.com> (raw)
In-Reply-To: <20221128021005.232105-3-lizetao1@huawei.com>
On 28.11.22 03:10, Li Zetao wrote:
> When doing the following test steps, an error was found:
> step 1: modprobe virtio_mem succeeded
> # modprobe virtio_mem <-- OK
>
> step 2: fault injection in virtio_mem_init()
> # modprobe -r virtio_mem <-- OK
> # ...
> CPU: 0 PID: 1837 Comm: modprobe Not tainted
> 6.1.0-rc6-00285-g6a1e40c4b995-dirty
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996)
> Call Trace:
> <TASK>
> should_fail.cold+0x5/0x1f
> ...
> virtio_mem_init_hotplug+0x9ae/0xe57 [virtio_mem]
> virtio_mem_init.cold+0x327/0x339 [virtio_mem]
> virtio_mem_probe+0x48e/0x910 [virtio_mem]
> virtio_dev_probe+0x608/0xae0
> ...
> </TASK>
> virtio_mem virtio4: could not reserve device region
> virtio_mem: probe of virtio4 failed with error -16
>
> step 3: modprobe virtio_net failed
virtio_net ?
> # modprobe virtio_mem <-- failed
> virtio_mem: probe of virtio4 failed with error -16
>
> The root cause of the problem is that the virtqueues are not
> stopped on the error handling path when virtio_mem_init()
> fails in virtio_mem_probe(), resulting in an error "-ENOENT"
> returned in the next modprobe call in setup_vq().
>
> virtio_pci_modern_device uses virtqueues to send or
> receive message, and "queue_enable" records whether the
> queues are available. In vp_modern_find_vqs(), all queues
> will be selected and activated, but once queues are enabled
> there is no way to go back except reset.
>
> Fix it by reset virtio device on error handling path. After
> virtio_mem_init_vq() succeeded, all virtqueues should be
> stopped on error handling path.
>
> Fixes: 1fcf0512c9c8 ("virtio_pci: modern driver")
That commit is from 2014. virtio-mem was merged in 2020
Fixes: 5f1f79bbc9e2 ("virtio-mem: Paravirtualized memory hotplug")
> Signed-off-by: Li Zetao <lizetao1@huawei.com>
> ---
> drivers/virtio/virtio_mem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
> index 0c2892ec6817..c7f09c2ce982 100644
> --- a/drivers/virtio/virtio_mem.c
> +++ b/drivers/virtio/virtio_mem.c
> @@ -2793,6 +2793,7 @@ static int virtio_mem_probe(struct virtio_device *vdev)
>
> return 0;
> out_del_vq:
> + virtio_reset_device(vdev);
> vdev->config->del_vqs(vdev);
> out_free_vm:
> kfree(vm);
Apart from that
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-11-28 8:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 2:10 [PATCH 0/4] Fix probe failed when modprobe modules Li Zetao
2022-11-28 2:10 ` [PATCH 1/4] 9p: Fix probe failed when modprobe 9pnet_virtio Li Zetao
2022-11-28 14:27 ` Christian Schoenebeck
2022-11-28 2:10 ` [PATCH 2/4] virtio-mem: Fix probe failed when modprobe virtio_mem Li Zetao
2022-11-28 8:22 ` David Hildenbrand [this message]
2022-11-28 2:10 ` [PATCH 3/4] virtio-input: Fix probe failed when modprobe virtio_input Li Zetao
2022-11-28 9:29 ` Michael S. Tsirkin
2022-11-28 2:10 ` [PATCH 4/4] virtio-blk: Fix probe failed when modprobe virtio_blk Li Zetao
2022-11-28 10:14 ` [PATCH 0/4] Fix probe failed when modprobe modules Michael S. Tsirkin
2022-11-29 3:37 ` Jason Wang
2022-12-19 10:15 ` Michael S. Tsirkin
2022-12-20 6:44 ` Jason Wang
2023-01-27 11:11 ` Michael S. Tsirkin
2023-01-29 5:50 ` Jason Wang
2022-11-29 16:06 ` [PATCH v2 0/5] " Li Zetao
2022-11-29 16:06 ` [PATCH v2 1/5] 9p: Fix probe failed when modprobe 9pnet_virtio Li Zetao
2022-11-29 16:06 ` [PATCH v2 2/5] virtio-mem: Fix probe failed when modprobe virtio_mem Li Zetao
2022-11-29 16:06 ` [PATCH v2 3/5] virtio-input: Fix probe failed when modprobe virtio_input Li Zetao
2022-11-29 16:06 ` [PATCH v2 4/5] virtio-blk: Fix probe failed when modprobe virtio_blk Li Zetao
2022-11-29 16:06 ` [PATCH v2 5/5] drm/virtio: Fix probe failed when modprobe virtio_gpu Li Zetao
2022-11-29 17:08 ` [PATCH v2 0/5] Fix probe failed when modprobe modules Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af62e7fe-d848-acb8-ca77-cdf01022b8de@redhat.com \
--to=david@redhat.com \
--cc=asmadeus@codewreck.org \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericvh@gmail.com \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lizetao1@huawei.com \
--cc=lucho@ionkov.net \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=stefanha@redhat.com \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).