From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751180AbdKEOnc (ORCPT ); Sun, 5 Nov 2017 09:43:32 -0500 Received: from mout.web.de ([212.227.15.4]:64586 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821AbdKEOna (ORCPT ); Sun, 5 Nov 2017 09:43:30 -0500 To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] video/fbdev/dnfb: Use common error handling code in dnfb_probe() Message-ID: Date: Sun, 5 Nov 2017 15:43:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:B2zMcGKBQli0KDD+camiUW+0h/JTHsVQoRxDyO22ma6GVvnvJfK Y/GAuvVGAcC0LFtqeLmJVfuuQFG4OHugc2Egs1FIHZMFfu0vOqEp5ZbFQMtwlAJcFiEkVib sdVBwop6RtbGOk0jGiHn0WVKYBcAPOz6wUNqLh9rIlcI4toUbxfZByZrOfUUMv9VUjf2e1r 5l/SHjhNdHuehPDEdMYRw== X-UI-Out-Filterresults: notjunk:1;V01:K0:rf3xixBtevM=:9Zsq5GVfMlC3QUZSDpPaWs P93airycFPNml2BPwroaAJnmbYhF7N5kG2bGIQb8sPNTHgZmWiYX5lwj+zoTo6vrlxS+Yv9k3 Q0XQOEQ98HVP4xqZFJw2lyyKrBBoYlqTnouyjk57aMx7kJJK/fd0qevkz1xirhScO2LikkUwc 9a2AWXfIRQjvYpTgGe9Sgk2d2E+f+MNrkdy9yFuXKf25o4951xW7WGEy+y/t9xJAMSNX6qEqB s+0kx+dbBOyPRJY1/Z/DE2wCqvoyDSmPdOAKx84gXUtytyroySFsqXDp8EubatOTxUdJCwJDN J8UNWSHV3mSyl+f0ZZnGVSMcmNEvSk8d/8gvsmduHKqiX38grsaPb532AZszztG9AxpJrLEeq e2liFEg2Lc+rPZiM/SEEFSbgBjV/8yQlXreZxjdJ4LixK1a/QeOsmbcNcTjbH5nGP2T/xQw22 TOM7dy3u7qferSuw58qcVN7YJAjbjuTEJz//ygzT315b7kDaZO20Llis6+TG2JT7wVPxh5wcC 3dVRhxQyfwAKs8cfuMJ0u+CRiCGZ1rVB87xIYtwZSS/GX/iZZmoR7HnwwRI+OBYrZXo28wDgI Ez1NNS+fmBgmXCVVW3xWhb70Qzh3n1APjnIAtMRqhAqlsP0ukQ6oYDusPes9uRgtv4QOghPM6 tkXDQgk9lPs28mrxzvHRk3uDa0v3rIWDOtfRuB3AooVyOmycf01/I8Qy/DlDhn4pG4+tv1gwS xSCu9e/cZboDfweTCKTMzRpAhZOY/G1dLqzkIzlB1JP72vJ5tCzqXKd47EViRC9GZ3idTdiqG x/mIevmQLzFhPtdn8atGTb8piwq3EPxpPei5VuxRbHMwa9l40Q= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 5 Nov 2017 14:54:52 +0100 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/dnfb.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/dnfb.c b/drivers/video/fbdev/dnfb.c index 09415009d797..5505fa00c634 100644 --- a/drivers/video/fbdev/dnfb.c +++ b/drivers/video/fbdev/dnfb.c @@ -242,16 +242,13 @@ static int dnfb_probe(struct platform_device *dev) info->screen_base = (u_char *) info->fix.smem_start; err = fb_alloc_cmap(&info->cmap, 2, 0); - if (err < 0) { - framebuffer_release(info); - return err; - } + if (err < 0) + goto release_framebuffer; err = register_framebuffer(info); if (err < 0) { fb_dealloc_cmap(&info->cmap); - framebuffer_release(info); - return err; + goto release_framebuffer; } platform_set_drvdata(dev, info); @@ -265,6 +262,10 @@ static int dnfb_probe(struct platform_device *dev) printk("apollo frame buffer alive and kicking !\n"); return err; + +release_framebuffer: + framebuffer_release(info); + return err; } static struct platform_driver dnfb_driver = { -- 2.15.0